Fixes #5058: add method to ensure lhs=rhs in files #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| create => "false", | ||
| edit_line => maintain_key_values("${array}", "${separator}"), | ||
| edit_defaults => no_backup, | ||
| classes => classes_generic("${class_prefix}"); |
|
I think the naming could be improved here. array" is really a terrible variable name, can we go with "keys" instead? Can we rename the whole bundle "file_ensure_keys_values"? |
|
PR has been updated |
| # | ||
| # @parameter file File name to edit | ||
| # @parameter keys Array with where keys are LHS and values are RHS | ||
| # @parameter separator Separator between LHS and RHS |
There was a problem hiding this comment.
Please update the description and parameter docs to use "key" instead of LHS and "value" instead of RHS.
Also the doc for the "keys" parameters doesn't make sense ("with where"...)
|
PR has been updated |
| # | ||
| ##################################################################################### | ||
|
|
||
| # @name File ensure lines with key->values |
There was a problem hiding this comment.
Oops, you didn't update the name after changing the bundle name!
Please use "File ensure keys->values present"
ncharles
force-pushed
the
bug_5058/dev/add_bundle_for_file_edition_lhs_rhs
branch
from
ac60e63
to
54e1c30
Compare
|
PR has been updated |
|
OK, merging |
peckpeck
added a commit
that referenced
this pull request
Feb 27, 2015
…_edition_lhs_rhs Fixes #5058: add method to ensure lhs=rhs in files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.