Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23816: Ansible collection should not try to check for OS version before installing the repositories and packages #70

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Nov 30, 2023

…on before installing the repositories and packages
@Fdall Fdall requested a review from amousset November 30, 2023 09:34
@Normation-Quality-Assistant

This PR breaks qa-test

-- stdout -- 
Branch 'master' set up to track remote branch 'master' from 'NRM'.
Your branch is up to date with 'NRM/master'.
Already up to date.
Already up to date.
[...]
Running merge tests
 $ cd "/srv/jenkins/jobs/merge-accepted-pr/workspace/repos/rudder-ansible" && ./qa-test --merge

-- stderr --
From github.com:Fdall/rudder-ansible
 * [new branch]      bug_23816/ansible_collection_should_not_try_to_check_for_os_version_before_installing_the_repositories_and_packages -> bug_23816/ansible_collection_should_not_try_to_check_for_os_version_before_installing_the_repositories_and_packages_pr
Switched to branch 'master'
Switched to a new branch 'master_test'
./qa-test: 12: typos: not found

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/rudder-ansible/pull/70 --test to test with upmerging.
After this, you can remove the qa: Can't merge ta
-- Your faithful QA (https://ci.normation.com/jenkins/job/merge-accepted-pr/76882/console)

…S version before installing the repositories and packages

Fixes #23816: Ansible collection should not try to check for OS version before installing the repositories and packages
@Fdall
Copy link
Contributor Author

Fdall commented Nov 30, 2023

PR updated with a new commit

@Fdall Fdall merged commit 15223c5 into Normation:master Nov 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants