Fixes #13442: Branding plugin doesn't build in branch 5.0 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
approved these changes
Sep 12, 2018
VinceMacBuche
requested changes
Sep 12, 2018
main-build.conf
Outdated
| @@ -21,4 +21,4 @@ lib-common-private=1.1 | |||
|
|
|||
| # Version of Rudder used to build the plugin. | |||
| # It defined the API/ABI used and it is important for binary compatibility | |||
| rudder-build-version=5.0.0~beta2-SNAPSHOT | |||
| rudder-build-version=5.0.0~beta3-SNAPSHOT | |||
There was a problem hiding this comment.
In fact we should use rc1-SNAPSHOT, or beta2 without snapshot
There was a problem hiding this comment.
or rc1 or rc2-SNAPSHOT now :)
ncharles
force-pushed
the
bug_13442/branding_plugin_doesn_t_build_in_branch_5_0
branch
from
2f46bb4
to
aaaa9dd
Compare
|
Commit modified |
|
OK, merging this PR |
VinceMacBuche
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/13442