-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #19059: rework 6.2.3/6.2.4 release notes #657
Fixes #19059: rework 6.2.3/6.2.4 release notes #657
Conversation
To prevent this type of problems (in the scope of a patch release) we had to totally prevent passing empty parameters to techniques from the technique editor. This makes missing parameters a policy generation error, allowing to safely provide | ||
them to directives after modifying the source technique. | ||
|
||
This may break existing directives that rely on an empty parameter (wether with an empty value or with an expression evaluating to an empty value, like a property containing an empty string). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could not set an empty value on this field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was rejected, only the case where you use a property with a default value is broken
PR updated with a new commit |
To prevent this type of problems (in the scope of a patch release) we had to totally prevent passing empty parameters to techniques from the technique editor. This makes missing parameters a policy generation error, allowing to safely provide | ||
them to directives after modifying the source technique. | ||
|
||
This may break existing directives that rely on an expression evaluating to an empty value, like a property containing an empty string, or a property value with an empty default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
evaluating -> Which evaluates
PR updated with a new commit |
This PR is not mergeable to upper versions. |
OK, squash merging this PR |
9354bc6
to
f5234e2
Compare
https://issues.rudder.io/issues/19059