Fixes #19059: rework 6.2.3/6.2.4 release notes #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| To prevent this type of problems (in the scope of a patch release) we had to totally prevent passing empty parameters to techniques from the technique editor. This makes missing parameters a policy generation error, allowing to safely provide | ||
| them to directives after modifying the source technique. | ||
|
|
||
| This may break existing directives that rely on an empty parameter (wether with an empty value or with an expression evaluating to an empty value, like a property containing an empty string). |
There was a problem hiding this comment.
you could not set an empty value on this field
There was a problem hiding this comment.
it was rejected, only the case where you use a property with a default value is broken
|
PR updated with a new commit |
| To prevent this type of problems (in the scope of a patch release) we had to totally prevent passing empty parameters to techniques from the technique editor. This makes missing parameters a policy generation error, allowing to safely provide | ||
| them to directives after modifying the source technique. | ||
|
|
||
| This may break existing directives that rely on an expression evaluating to an empty value, like a property containing an empty string, or a property value with an empty default. |
There was a problem hiding this comment.
evaluating -> Which evaluates
|
PR updated with a new commit |
VinceMacBuche
approved these changes
Mar 23, 2021
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
amousset
force-pushed
the
bug_19059/rework_6_2_3_6_2_4_release_notes
branch
from
9354bc6
to
f5234e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/19059