Fixes #10275: When we add/remove/update a tag to a Directive/Rule, we get an empty event log #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… get an empty event log
| @@ -161,7 +161,7 @@ class DirectiveUnserialisationImpl extends DirectiveUnserialisation { | |||
| priority <- (directive \ "priority").headOption.flatMap(s => tryo { s.text.toInt } ) ?~! ("Missing or bad attribute 'priority' in entry type directive : " + xml) | |||
| isSystem <- (directive \ "isSystem").headOption.flatMap(s => tryo { s.text.toBoolean } ) ?~! ("Missing attribute 'isSystem' in entry type directive : " + xml) | |||
| policyMode = (directive \ "policyMode").headOption.flatMap(s => PolicyMode.parse(s.text) ) | |||
| directiveIds = (directive \ "directiveIds" \ "id" ).map( n => DirectiveId( n.text ) ).toSet | |||
There was a problem hiding this comment.
funny ... should be empty quite often ...
There was a problem hiding this comment.
Yeah, not sur what was the intent of that code, since directiveIds is never used... Perhaps some debug code that get kept, no idea.
There was a problem hiding this comment.
I think it was a copy paste from Rule diff
|
OK, merging this PR |
|
OK, merging this PR |
fanf
deleted the
bug_10275/when_we_add_remove_update_a_tag_to_a_directive_rule_we_get_an_empty_event_log
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10275