Fixes #10383: If I click on "Regenerate all policies", it clears the cache of changes, and slows down a lot the web interface #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to rebase your pull request |
| set | ||
| }) match { | ||
| case eb:EmptyBox => | ||
| val e = eb ?~! "Error when logging the cache event" |
There was a problem hiding this comment.
The error may not be wile logging the cache event but also when clearNodeConfigurationCache fails
| EventLogDetails( | ||
| modificationId = Some(modId) | ||
| , principal = CurrentUser.getActor | ||
| , details = EventLog.emptyDetails | ||
| , reason = None))) match { | ||
| , reason = Some("Node configuration caches deleted on user request") |
There was a problem hiding this comment.
"cache" instead of "caches"
…e cache of changes, and slows down a lot the web interface
|
PR rebased |
fanf
force-pushed
the
bug_10383/if_i_click_on_regenerate_all_policies_it_clears_the_cache_of_changes_and_slows_down_a_lot_the_web_interface
branch
from
65eb9f1
to
efac891
Compare
|
OK, merging this PR |
fanf
deleted the
bug_10383/if_i_click_on_regenerate_all_policies_it_clears_the_cache_of_changes_and_slows_down_a_lot_the_web_interface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10383