-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #16201: Inefficient computing of compliance on home page #2615
Fixes #16201: Inefficient computing of compliance on home page #2615
Conversation
Do not merge, need more work |
941f0df
to
61a73ce
Compare
Commit modified |
@@ -455,7 +434,7 @@ trait DefaultFindRuleNodeStatusReports extends ReportingService { | |||
} yield { | |||
val t2 = System.currentTimeMillis | |||
//we want to have nodeStatus for all asked node, not only the ones with reports | |||
val nodeStatusReports = runInfos.map { case (nodeId, runInfo) => | |||
val nodeStatusReports = runInfos.par.map { case (nodeId, runInfo) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this part hasn't been tested yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but without the par, with 5000 nodes it takes 22s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a linear improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for reference: this causes deadlocks - see https://issues.rudder.io/issues/16256
Commit modified |
61a73ce
to
6d33a8a
Compare
This PR is not mergeable to upper versions. |
OK, merging this PR |
OK, merging this PR |
1 similar comment
OK, merging this PR |
)) | ||
} | ||
def getGlobalUserCompliance(): Box[Option[(ComplianceLevel, Long)]] = { | ||
val n1 = System.currentTimeMillis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha, i forgot to remove this one
OK, merging this PR |
https://issues.rudder.io/issues/16201