Fixes #16629: Use only one ZIO threadpool to enhance performances #2743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16629
This change leads to a 20% improvement in Rudder policy generation time, from around 25 minutes to below 20 minutes.
This change allowed to workaround three things described here: zio/zio#1275 (comment)
identity
)effectBlocking
manage the discarding of the underlying thread, which we generally don't want.The last two are already corrected in ZIO-RC18! And the first one is not that bad anymore.
So, I'm not sure I we should commit that complicated PR or just wait for RC18 (which is stabilising and will likely be ZIO 1.0.0)