Fixes #20446: Don't insert partial runs as run logs #4062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
|
PR updated with a new commit |
|
PR updated with a new commit |
|
PR updated with a new commit |
amousset
commented
Dec 16, 2021
| @@ -67,12 +71,6 @@ pub enum RunlogInsertion { | |||
| AlreadyThere, | |||
| } | |||
|
|
|||
| #[derive(Clone, Copy, Debug, PartialEq, Eq)] | |||
There was a problem hiding this comment.
Remove this as it makes no sense anymore
amousset
commented
Dec 16, 2021
| @@ -5,6 +5,19 @@ | |||
| }, | |||
| "config_id": "20200324-102421-f6947255", | |||
| "reports": [ | |||
| { | |||
There was a problem hiding this comment.
the start was skipped due to the non-timestamped line in
. They should never appear there is the wild, but I kept them to ensure the parser does not explode if it happens.
ncharles
approved these changes
Dec 16, 2021
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
amousset
force-pushed
the
bug_20446/don_t_insert_partial_runs_as_run_logs
branch
from
5fcf5c1
to
c15a534
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/20446