Fixes #21854: Properly configure CSP violation handler #4512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Produces logs like: |
|
PR updated with a new commit |
amousset
commented
Sep 25, 2022
| @@ -362,6 +364,12 @@ class Boot extends Loggable { | |||
| // the session itself. | |||
| LiftRules.noCometSessionCmd.default.set(() => JsCmd.unitToJsCmd(())) | |||
|
|
|||
| // Log CSP violations | |||
| LiftRules.contentSecurityPolicyViolationReport = (r: ContentSecurityPolicyViolation) => { | |||
| ApplicationLogger.warn(s"Content security policy violation: blocked ${r.blockedUri} in ${r.documentUri} because of ${r.violatedDirective} directive") | |||
There was a problem hiding this comment.
I haven't investigated how to log it the right context, Application looks a bit too generic.
fanf
approved these changes
Sep 27, 2022
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
amousset
force-pushed
the
arch_21854/properly_configure_csp_violation_handler
branch
from
3aa6d2f
to
bdcacd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/21854