Fixes #22371: missing report in change only #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
fanf
commented
Mar 1, 2023
| @@ -1718,7 +1719,15 @@ object ExecutionBatch extends Loggable { | |||
| case x if (x <= cardinality) => | |||
| filteredReports.map(_.toMessageStatusReport(policyMode)).toList ++ | |||
| /* We need to complete the list of correct with missing, if some are missing */ | |||
| (x until cardinality).map(i => MessageStatusReport(ReportType.Missing, s"[Missing report #${i}]")).toList | |||
There was a problem hiding this comment.
ReportType.Missing in place of noAnswerType is the culprit here
VinceMacBuche
approved these changes
Mar 1, 2023
|
This PR is not mergeable to upper versions. |
|
PR rebased |
fanf
force-pushed
the
bug_22371/missing_report_in_change_only
branch
from
4ddb8ab
to
490f06b
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/22371