Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22573: Allow generating runnable techniques #4739

Merged
merged 1 commit into from
May 2, 2023
Merged

Fixes #22573: Allow generating runnable techniques #4739

merged 1 commit into from
May 2, 2023

Conversation

amousset
Copy link
Member

@amousset amousset commented Apr 3, 2023

@amousset amousset requested a review from Fdall April 3, 2023 19:13
@amousset amousset marked this pull request as draft April 3, 2023 19:13
@amousset
Copy link
Member Author

amousset commented Apr 3, 2023

PR updated with a new commit

1 similar comment
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset amousset force-pushed the arch_22573/allow_generating_runnable_techniques branch from 9693a7f to 0b0e893 Compare April 12, 2023 08:00
@Fdall
Copy link
Contributor

Fdall commented Apr 12, 2023

Looks good, could you add a line in the CLI output with the command line to run to execute the standalone policy?

@amousset
Copy link
Member Author

I will, but it is still missing the bundle to actually call the technique

@amousset
Copy link
Member Author

PR updated with a new commit

12 similar comments
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR rebased

@amousset amousset force-pushed the arch_22573/allow_generating_runnable_techniques branch from 640ba5f to be65044 Compare April 28, 2023 16:06
@amousset
Copy link
Member Author

PR updated with a new commit

1 similar comment
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset amousset marked this pull request as ready for review April 28, 2023 16:26
@amousset
Copy link
Member Author

PR updated with a new commit

4 similar comments
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented May 1, 2023

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/4739
-- Your faithful QA
Kant merge: "Live your life as though your every act were to become a universal law."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/68033/console)

@amousset
Copy link
Member Author

amousset commented May 2, 2023

OK, squash merging this PR

@amousset amousset force-pushed the arch_22573/allow_generating_runnable_techniques branch from 8a584ff to 30a3607 Compare May 2, 2023 07:40
@amousset amousset merged commit 30a3607 into Normation:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdall Fdall Fdall approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amousset @Fdall @Normation-Quality-Assistant