Fixes #23332: Serde errors do not point to the correct line number #5226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23332
Solves probably 75% of the problem with a low effort.
The idea is to avoid parsing an untagged enum with serde (as it totally breaks error reporting), and use a plain struct instead, and then convert manually to the different kinds.
The higher level errors still do not point to a line in the source (but it was never the case, and would require heavy lifting, like replacing serde with a lower level YAML parser), but all reporting error line are now correct.