Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25479: Users cleanup configuration is too strict on disabled users #5880

Conversation

clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory commented Sep 17, 2024

https://issues.rudder.io/issues/25479

  • Add an appropriate log with the application.authentication name and use it in the CleanupUsers file
  • Improve logs globally : add some missing logs (for disable/purged) and use zio.Duration#render to display the date
  • Only apply deletion of inactive only on disabled users

As for the properties file :

  • Allow to parse "never" as zio.Duration.Infinity, when used in the config the existing logic of the code is still valid (eventually the code is disabling/deletion is never run)
  • Improve the comments and update default to 90 days for disableAfterLastLogin

Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.
in an other pr, we will need to merge all logs toward "application.authentication".

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit e45877b into Normation:branches/rudder/8.1 Sep 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants