Fixes #7059: In UI, directives in a rule are not sorted as their bundle order #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
force-pushed
the
bug_7059/in_ui_rules_and_directives_in_rules_are_not_sorted_as_their_bundle_order
branch
from
3cba32a
to
48b5802
Compare
| arr.push({"id":o, "name": $scope.directives[o] }); | ||
| } | ||
| var sorted = arr.sort(function(a, b) { | ||
| return a.name.localeCompare(b.name); |
There was a problem hiding this comment.
this is unfortunately not compatible IE10 :(
There was a problem hiding this comment.
oh, my bad, this existed already in IE6
http://stackoverflow.com/questions/51165/how-do-you-do-string-comparison-in-javascript
ncharles
added a commit
that referenced
this pull request
Aug 4, 2015
…_in_rules_are_not_sorted_as_their_bundle_order Fixes #7059: In UI, directives in a rule are not sorted as their bundle order
fanf
deleted the
bug_7059/in_ui_rules_and_directives_in_rules_are_not_sorted_as_their_bundle_order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7059
Some information about that pull request: AngularJS needs to have stable JS object or it goes in infinite loop. So I need to have both the data I need, with the model I want to handle AND a copy of them on an angularjs-no-infinity-loop compatible way. That su**s. Not found anything else.