This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
Projects endpoint & table #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescd18
added
front-end
|
HOLD: Please don't merge it yet even if it's approved. |
kevinyu328
reviewed
Feb 8, 2021
|
Ooops! My bad, here's the screenshot. |
|
Full functionality: mock data --> api endpoint --> container fetched it --> container displays data in table |
kevinyu328
previously approved these changes
Feb 8, 2021
eshwaribhide
previously approved these changes
Feb 8, 2021
This was referenced Feb 11, 2021
jamescd18
dismissed stale reviews from eshwaribhide and kevinyu328
via
367dbc3
kevinyu328
previously approved these changes
Feb 12, 2021
eshwaribhide
previously approved these changes
Feb 12, 2021
jamescd18
dismissed stale reviews from eshwaribhide and kevinyu328
via
57bb362
14 tasks
eshwaribhide
approved these changes
Feb 17, 2021
joongpa
added a commit
that referenced
this pull request
Mar 18, 2021
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops I realized this actually closes #67 and closes #66 too. Todo: add more tests for the added functionality
later: fix the default sort once the API endpoint is actually properly set up and convert the business logic to integrate with redux