[BUGFIX & new example]: add new example and BUGFIX for __AVR__ for function DS3231::setEpoch() #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasenradball
changed the title
hasenradball
changed the title
|
Resuming work on this library as of Sept 5 2022. Intend to merge this PR later today after testing the bugfix and the new example on various Arduino platforms. |
IowaDave
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
These proposed changes test correctly for both AVR (ATmega328P on a Nano) and ESP8266 (Lolin Wemos D1 mini clone). After setting the clock mode to 12-hour and giving the value 1659875100 for epoch, the fixed code loaded the DS3231 with correct date and time values for Aug 07 2022 12:25:00 P.M.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in PR #65.