Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Fix dataset path check #419

Merged
merged 3 commits into from
Apr 17, 2024
Merged

[hotfix] Fix dataset path check #419

merged 3 commits into from
Apr 17, 2024

Conversation

illian01
Copy link
Collaborator

@illian01 illian01 commented Apr 17, 2024

Description

Please include a summary of this pull request in English. If it closes an issue, please mention it here.

Fix: #253

We recommend to link at least one existing issue for PR. Before your create a PR, please check if there is an issue for this change.

Change(s)

  • Call dataset_path_check only for local dataset

Code Formatting

If you PR to either master or dev branch, you should follow the code linting process. Please check your code with lint_check.sh in ./scripts directory.
For more information, please read the contribution guide in CONTRIBUTING.md.

Changelog

If your PR is granted to dev branch, codeowner will add a brief summary of the change to the Upcoming Release section of the CHANGELOG.md file including a link to the PR (formatted in markdown) and a link to your github profile.

For example,

- Added a new feature by `@myusername` in [PR 2023](https://github.com/Nota-NetsPresso/netspresso-trainer/pull/2023)

@illian01 illian01 requested a review from shinkookchoi April 17, 2024 02:22
@illian01 illian01 self-assigned this Apr 17, 2024
@illian01 illian01 added the bug Something isn't working label Apr 17, 2024
@illian01 illian01 marked this pull request as ready for review April 17, 2024 02:25
@illian01 illian01 merged commit 5261867 into dev Apr 17, 2024
2 checks passed
@illian01 illian01 deleted the 253-dataset-validator branch May 2, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sprint] Adding dataset validator
1 participant