Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: postprocessors/register.py -> registry.py #424

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

aychun
Copy link
Contributor

@aychun aychun commented Apr 19, 2024

Description

Change the file name of post-processor registry to match with others.

Closes: #423

We recommend to link at least one existing issue for PR. Before your create a PR, please check if there is an issue for this change.

Change(s)

  • postprocessors/register.py -> postprocessors/registry.py

Code Formatting

If you PR to either master or dev branch, you should follow the code linting process. Please check your code with lint_check.sh in ./scripts directory.
For more information, please read the contribution guide in CONTRIBUTING.md.

Changelog

If your PR is granted to dev branch, codeowner will add a brief summary of the change to the Upcoming Release section of the CHANGELOG.md file including a link to the PR (formatted in markdown) and a link to your github profile.

For example,

- Added a new feature by `@myusername` in [PR 2023](https://github.com/Nota-NetsPresso/netspresso-trainer/pull/2023)

@aychun aychun requested a review from illian01 as a code owner April 19, 2024 05:40
Copy link
Collaborator

@illian01 illian01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request! It looks good to me.
I'm going to update CHANGELOG.md. Can you activate allow edits and access to secrets by maintainers button?

@illian01 illian01 merged commit e405599 into Nota-NetsPresso:dev Apr 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Unify registry file names
2 participants