Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test directory check line #428

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Fix test directory check line #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0ea3b5
Fix test directory check line
illian01 Apr 22, 2024
70dbe9b
Update CHANGELOG.md
illian01 Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

## Bug Fixes:

No changes to highlight.
- Fix test directory check line by `@illian01` in [PR 428](https://github.com/Nota-NetsPresso/netspresso-trainer/pull/428)

## Breaking Changes:

Expand Down
2 changes: 1 addition & 1 deletion src/netspresso_trainer/dataloaders/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def dataset_path_check(conf_data: DictConfig, mode: Literal['train', 'test']):
conf_data.path.test.label = None

elif mode == 'test':
assert conf_data.path.train.test_dataset is not None, "For test, test split of dataset must be provided."
assert conf_data.path.test.image is not None, "For test, test split of dataset must be provided."

if conf_data.path.train.image:
logger.warning('For test (evaluation or inference), train split of dataset is not needed. This field will be ignored.')
Expand Down
Loading