Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor typos and logging #440

Merged
merged 1 commit into from
May 3, 2024
Merged

Minor typos and logging #440

merged 1 commit into from
May 3, 2024

Conversation

illian01
Copy link
Collaborator

@illian01 illian01 commented May 3, 2024

Description

Please include a summary of this pull request in English. If it closes an issue, please mention it here.

Closes: #(issue number)

We recommend to link at least one existing issue for PR. Before your create a PR, please check if there is an issue for this change.

Change(s)

  • Minor typos and logging

Code Formatting

If you PR to either master or dev branch, you should follow the code linting process. Please check your code with lint_check.sh in ./scripts directory.
For more information, please read the contribution guide in CONTRIBUTING.md.

Changelog

If your PR is granted to dev branch, codeowner will add a brief summary of the change to the Upcoming Release section of the CHANGELOG.md file including a link to the PR (formatted in markdown) and a link to your github profile.

For example,

- Added a new feature by `@myusername` in [PR 2023](https://github.com/Nota-NetsPresso/netspresso-trainer/pull/2023)

Please enable Allow edits and access to secrets by maintainers so that our maintainers can update the CHANGELOG.md.

@illian01 illian01 added no-changelog-update refactoring Changes code or architecture internally without changing the output. labels May 3, 2024
@illian01 illian01 requested a review from shinkookchoi May 3, 2024 01:44
@illian01 illian01 self-assigned this May 3, 2024
@illian01 illian01 marked this pull request as ready for review May 3, 2024 01:45
@illian01 illian01 merged commit e2f57e1 into dev May 3, 2024
6 checks passed
@illian01 illian01 deleted the minor-fix branch May 3, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-update refactoring Changes code or architecture internally without changing the output.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant