Ratio improvements & fixes #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the ratio group tab (for the ratio plugin) in the ruTorrent settings menu.
The following changes are made by this pull request:
The UL value is now measured in gigabytes instead of megabytes.
The default UL value is increased from 20MB to 100MB.
The min UL value is increased from 1MB to 10MB.
The max UL value is increased from 1TB to 1PB.
The UL value now accepts 2 decimal places.
A regression from Refactor code & implement autoloader #2247 is fixed when setting the ratio group UL Targets. The Math class was not referenced properly
A new translated legend is added beside the default ratio group selector. This explains to the user how the UL value works. It also makes it easier for the user to do terabyte and megabyte conversations, without having to look up the values.
Here is a screenshot of how the ratio group tab looks now:
What is the motivation behind these changes?
I wanted to set a 3 terabyte UL value for my torrent. I was not able to do that. 999999 megabytes which equals 1 terabyte was the max value. Also, it was difficult to set gigabyte UL values because the measurement unit was megabytes. Bandwidth has increased significantly since ruTorrent was first released. Setting megabyte UL values is no longer applicable for many people.