Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused localized resources in nuget.exe #12066

Closed
dominoFire opened this issue Aug 31, 2022 · 0 comments · Fixed by NuGet/NuGet.Client#4779
Closed

Remove unused localized resources in nuget.exe #12066

dominoFire opened this issue Aug 31, 2022 · 0 comments · Fixed by NuGet/NuGet.Client#4779
Assignees
@dominoFire
Labels
Priority:2 Issues for the current backlog. Product:NuGet.exe NuGet.exe Tenet:WorldReady Type:Bug
Milestone
6.4

Comments

@dominoFire
Copy link
Contributor

dominoFire commented Aug 31, 2022 •
edited
Loading

There are localized resources that are never used in nuget.exe

This could help in reducing nuget.exe binary file size.

Unused nuget.exe resouces list

NuGetResources.resx:

  • Warning_SymbolServerNotConfigured_*: Equivalent resource exists in NuGet.Protocol assembly.
  • UnableToFindFile_*: Equivalent resource exists in NuGet.Protocol assembly. Search link
  • PushCommandPackagePushed_*: Equivalent resource exists in NuGet.Protocol assembly. Search
  • NoApiKeyFound_*: Equivalent resource exists in NuGet.Protocol assembly. Search
  • DeleteCommandDeletingPackage_*: Equivalent resource exists in NuGet.Protocol assembly. Search
  • DeleteCommandDeletedPackage_*: Equivalent resource exists in NuGet.Protocol assembly. Search
  • DeleteCommandCanceled_*: Equivalent resource exists in NuGet.Protocol assembly. Search
  • DeleteCommandConfirm_*: Equivalent resource exists in NuGet.Protocol assembly. Search
  • Error_SourceProviderIsNull_*: There is no English string resource.

NuGetCommands.resx:

  • InstallCommandDisableParallel_*: String resource are not directly referenced. May be replaced by CommandDisableParallelProcessing
  • InstallCommandNoCache_*: String resources are not directly referenced.
  • InstallCommandSourceDescription_*: String resources are not directly referenced.
  • RestoreCommandDisableParallelProcessing_*: String resources are not directly referenced.
  • RestoreCommandNoCache_*: String resources are not directly referenced.
  • RestoreCommandSourceDescription_*: String resources are not directly referenced. It may be replaced with general -source command argument for all nuget.exe commands.
@dominoFire dominoFire added Priority:2 Issues for the current backlog. Type:Bug Product:NuGet.exe NuGet.exe Tenet:WorldReady labels Aug 31, 2022
@dominoFire dominoFire self-assigned this Aug 31, 2022
This was referenced Aug 31, 2022
Closed
Merged
dominoFire pushed a commit to NuGet/NuGet.Client that referenced this issue Sep 6, 2022
Removes unused string resources in nuget.exe (#4779)
5b433fc 
Fixes NuGet/Home#12066 

Removes unused string resources found in nuget.exe localization work.
@jebriede jebriede added this to the 6.4 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominoFire dominoFire

Labels
Priority:2 Issues for the current backlog. Product:NuGet.exe NuGet.exe Tenet:WorldReady Type:Bug
Projects
None yet
Milestone
6.4
Development

Successfully merging a pull request may close this issue.

Removes unused string resources in nuget.exe NuGet/NuGet.Client
2 participants
@dominoFire @jebriede