New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuget.exe update drops the assembly strong name and Private attribute. #1778

Closed
emgarten opened this Issue Nov 25, 2015 · 3 comments

Comments

Projects
None yet
8 participants
@emgarten
Contributor

emgarten commented Nov 25, 2015

nuget.exe update drops the assembly strong name and <Private> attribute.

This is not a regression from 2.8.6.

Steps

  1. Create a new C# console app
  2. Install-Package newtonsoft.json -version 6.0.4
  3. Save and close the solution
  4. nuget.3.3.0.exe update .\packages.config -Safe

From VS:

    <Reference Include="Newtonsoft.Json, Version=6.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL">
      <HintPath>..\packages\Newtonsoft.Json.6.0.4\lib\net45\Newtonsoft.Json.dll</HintPath>
      <Private>True</Private>
    </Reference>

From nuget.exe:

    <Reference Include="Newtonsoft.Json">
      <HintPath>..\packages\newtonsoft.json.6.0.8\lib\net45\Newtonsoft.Json.dll</HintPath>
    </Reference>
@jainaashish

This comment has been minimized.

Show comment
Hide comment
Contributor

jainaashish commented May 18, 2016

@zhili1208 zhili1208 modified the milestones: 3.5 Beta2, 3.6 Beta Jun 22, 2016

@mdkf

This comment has been minimized.

Show comment
Hide comment
@mdkf

mdkf Sep 8, 2016

Just tested 3.5.0-RC1 command line client, instead of dropping the private tag it changed it from False to True.

mdkf commented Sep 8, 2016

Just tested 3.5.0-RC1 command line client, instead of dropping the private tag it changed it from False to True.

@ferdaarikan

This comment has been minimized.

Show comment
Hide comment
@ferdaarikan

ferdaarikan Apr 25, 2017

Is the commit always adding the fully qualified name? The bug report was complaining about the strong name being removed. Seems like fix is always adding the strong name. We have some use cases that strong name is intentionally excluded from the reference entry. It seems like this fix is breaking the functionality.

ferdaarikan commented Apr 25, 2017

Is the commit always adding the fully qualified name? The bug report was complaining about the strong name being removed. Seems like fix is always adding the strong name. We have some use cases that strong name is intentionally excluded from the reference entry. It seems like this fix is breaking the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment