Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSIX built locally should have the same dlls and files as the CI build. #2401

Closed
deepakaravindr opened this issue Mar 25, 2016 · 2 comments
Closed

VSIX built locally should have the same dlls and files as the CI build. #2401

deepakaravindr opened this issue Mar 25, 2016 · 2 comments
Assignees
@alpaix
Labels
Priority:1 High priority issues that must be resolved in the current sprint. Type:Bug
Milestone
3.5 Beta2

Comments

@deepakaravindr
Copy link

VSIX built locally should have the same dlls and files as the CI build.
Today, VSIX built locally has all the dlls from the output path.
However, the CI build has a whitelist of dlls to be included in the VSIX. This elimination is the last step before sending the VSIX for signing.

Locally built VSIX should have the same reduced number of dlls and files too
@rrelyea rrelyea added this to the 3.5 Beta milestone Mar 29, 2016
@pspill pspill mentioned this issue Apr 1, 2016
Closed
@pspill
Copy link

pspill commented Apr 1, 2016

This was hit in #2419 by a contributor building releases-3.4.1. We should ensure this fix makes it in to any branches that contributors are working in.

@yishaigalatzer yishaigalatzer modified the milestones: 3.5 Beta, 3.5 RC Apr 8, 2016
@rrelyea rrelyea assigned alpaix and unassigned deepakaravindr Apr 15, 2016
@rrelyea rrelyea added Type:Bug Priority:1 High priority issues that must be resolved in the current sprint. labels Apr 15, 2016
@rrelyea rrelyea mentioned this issue Apr 15, 2016
Closed
@AArnott
Copy link
Contributor

AArnott commented Apr 18, 2016

This is a common problem for VSIX's. Check out the VsixSuppression NuGet package. You may install it to solve this problem, or at least to learn how to solve the problem for yourself.

alpaix added a commit to alpaix/NuGet.Client that referenced this issue Apr 19, 2016
@alpaix
Added include and ignore lists to VSIX build
38c3e4e 
Fixes NuGet/Home#2401.
Fixes NuGet/Home#2419.
Fixes NuGet/Home#2546.

- Added files with include and ignore files lists matching CI script.
- Integrated include and ignore lists validation into VSIX build project.
- Removed redundant dependencies and added missing ones.
@alpaix alpaix mentioned this issue Apr 19, 2016
Merged
alpaix added a commit to alpaix/NuGet.Client that referenced this issue Apr 27, 2016
@alpaix
Added include and ignore lists to VSIX build
36d5afc 
Fixes NuGet/Home#2401.
Fixes NuGet/Home#2419.
Fixes NuGet/Home#2546.

- Added files with include and ignore files lists matching CI script.
- Integrated include and ignore lists validation into VSIX build project.
- Removed redundant dependencies and added missing ones.
alpaix added a commit to NuGet/NuGet.Client that referenced this issue Apr 28, 2016
@alpaix
Added include and ignore lists to VSIX build
608819e 
Fixes NuGet/Home#2401.
Fixes NuGet/Home#2419.
Fixes NuGet/Home#2546.

- Added files with include and ignore files lists matching CI script.
- Integrated include and ignore lists validation into VSIX build project.
- Removed redundant dependencies and added missing ones.
@alpaix alpaix modified the milestones: 3.5 Beta2, 3.5 RC Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alpaix alpaix

Labels
Priority:1 High priority issues that must be resolved in the current sprint. Type:Bug
Projects
None yet
Milestone
3.5 Beta2
Development

No branches or pull requests
6 participants
@AArnott @yishaigalatzer @deepakaravindr @alpaix @rrelyea @pspill