New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSIX built locally should have the same dlls and files as the CI build. #2401

Closed
deepakaravindr opened this Issue Mar 25, 2016 · 2 comments

Comments

Projects
None yet
6 participants
@deepakaravindr
Member

deepakaravindr commented Mar 25, 2016

VSIX built locally should have the same dlls and files as the CI build.
Today, VSIX built locally has all the dlls from the output path.
However, the CI build has a whitelist of dlls to be included in the VSIX. This elimination is the last step before sending the VSIX for signing.

Locally built VSIX should have the same reduced number of dlls and files too

@pspill

This comment has been minimized.

Show comment
Hide comment
@pspill

pspill Apr 1, 2016

This was hit in #2419 by a contributor building releases-3.4.1. We should ensure this fix makes it in to any branches that contributors are working in.

pspill commented Apr 1, 2016

This was hit in #2419 by a contributor building releases-3.4.1. We should ensure this fix makes it in to any branches that contributors are working in.

@AArnott

This comment has been minimized.

Show comment
Hide comment
@AArnott

AArnott Apr 18, 2016

Contributor

This is a common problem for VSIX's. Check out the VsixSuppression NuGet package. You may install it to solve this problem, or at least to learn how to solve the problem for yourself.

Contributor

AArnott commented Apr 18, 2016

This is a common problem for VSIX's. Check out the VsixSuppression NuGet package. You may install it to solve this problem, or at least to learn how to solve the problem for yourself.

alpaix added a commit to alpaix/NuGet.Client that referenced this issue Apr 19, 2016

Added include and ignore lists to VSIX build
Fixes NuGet/Home#2401.
Fixes NuGet/Home#2419.
Fixes NuGet/Home#2546.

- Added files with include and ignore files lists matching CI script.
- Integrated include and ignore lists validation into VSIX build project.
- Removed redundant dependencies and added missing ones.

alpaix added a commit to alpaix/NuGet.Client that referenced this issue Apr 27, 2016

Added include and ignore lists to VSIX build
Fixes NuGet/Home#2401.
Fixes NuGet/Home#2419.
Fixes NuGet/Home#2546.

- Added files with include and ignore files lists matching CI script.
- Integrated include and ignore lists validation into VSIX build project.
- Removed redundant dependencies and added missing ones.

alpaix added a commit to NuGet/NuGet.Client that referenced this issue Apr 28, 2016

Added include and ignore lists to VSIX build
Fixes NuGet/Home#2401.
Fixes NuGet/Home#2419.
Fixes NuGet/Home#2546.

- Added files with include and ignore files lists matching CI script.
- Integrated include and ignore lists validation into VSIX build project.
- Removed redundant dependencies and added missing ones.

@alpaix alpaix modified the milestones: 3.5 Beta2, 3.5 RC Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment