-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design and implement a notion of package type to support tool packages #2476
Comments
Working document: |
Context: I chatted with @yishaigalatzer about using PackageType for a different type of packages (not related to CLI tools). My main feedback on the working document is that it is too much about addressing .NET CLI Tools. The proposal may be more general, but the document does not convey that well. It would be nice to rephrase it in a more general way, with CLI tools being used as just an example, rather than it being the goal of the feature. |
@davidebbo, thanks for the feedback. Totally agreed. I was shooting for a specific, well-understood scenario to inform package type. Package type could potentially be a concept that blows up with too many requirements (considering that NuGet is already used for all sorts of, well, "versioned blob" delivery, i.e. Chocolatey, Octopus deployments, etc). Could you provide some more details about your specific scenario? Depending on your scenario, one detail you may find concerning is under the Installation heading:
This is talking about the installation procedure invoked in the Visual Studio UI or the |
@davidebbo, @harikm86, I've improve the documentation to walk through a simple custom package type example: |
I can give two specific scenarios:
In both scenarios:
Does that look like it will be covered by the current design? |
yes |
Adding @shrimpy who will help with this on Azure side |
@joelverhagen per in-person discussion yesterday, is the spec outdated? The wiki says:
https://github.com/NuGet/Home/wiki/Package-Type#installation |
Yes, good catch. I'll fix up the document. The second paragraph (vaguely) asserts the intended design.
Our in-person discussion yesterday was correct. |
This was completed with NuGet/NuGet.Client#680. |
Who owns writing and publishing the doc? From: Joel Verhagen notifications@github.com This was completed with NuGet/NuGet.Client#680NuGet/NuGet.Client#680. You are receiving this because you were mentioned. |
Joel has written this doc and i will publish it when we go live. Currently this is hanging off our new docs site branch, I will move this to master since we wont be going live untill the 8th. |
Let's publish now, as we don't need his code, this a guidance to package authors From: Harikrishna Menon notifications@github.com Joel has written this doc and i will publish it when we go live. Currently this is hanging off our new docs site branch, I will move this to master since we wont be going live untill the 8th. You are receiving this because you were mentioned. |
Published: |
The goal is have a way to mark a package as a tool so that it can be properly installed to the "tools" node in the project.json (instead of under "dependencies").
The text was updated successfully, but these errors were encountered: