Microsoft.Build.Evaluation.Project.Save() clears empty lines from a csproj

[mishra14]

From @mishra14 on August 1, 2017 23:0

Original issue: https://github.com/dotnet/cli/issues/7280

==================================================================

Steps to reproduce

dotnet new a console app
dotnet add package

Expected behavior

whitespace between itemgroups etc is preserved

Actual behavior

All blank lines are removed

Environment data

dotnet --info output:

Product Information:
 Version:            2.0.0-preview3-006770
 Commit SHA-1 hash:  78e7163819

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.15063
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.0.0-preview3-006770\

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.0-preview3-25514-02
  Build    : 1b047a04057cec973cfb890fd21f7a639cfcd118

Copied from original issue: dotnet/msbuild#2376

[mishra14]

I think this is an msbuild issue as NuGet invokes msbuild API's to read a csproj, add items/itemgroups and then save the csproj file.

[mishra14]

From @rainersigwald on August 1, 2017 23:9

@mishra14 #1036 added a new argument to ProjectRootElement.Open to preserve the existing formatting of the file. Can you opt NuGet into it? That's what CPS did for VS-based edits.

[mishra14]

I see. I guess NuGet can take this. I will move this issue out.

[mishra14]

@rainersigwald I dont see -
public static ProjectRootElement Open(string path, bool? preserveFormatting); overload.
Whats the best option for this call?

[rrelyea]

Unsure if CLI fixes from NuGet would have a ship vehicle in 15.4... May wait until 15.5.
Happy to go ahead and do this kind of fix in 4.4, as long as we ensure we test it well now.

[mishra14]

Merged: NuGet/NuGet.Client@d420ac3