Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SignedPackageArchive verification if the signature is not the last entry in the zip #6212

Closed
mishra14 opened this issue Nov 22, 2017 · 0 comments

Comments

@mishra14
Copy link
Contributor

No description provided.

mishra14 pushed a commit to NuGet/NuGet.Client that referenced this issue Nov 22, 2017
## Bug
Fixes: NuGet/Home#6175

## Fix
Details: This PR adds support for signing format which includes adding signature file to the package. The verification changes to calculating the hash of a signed package excluding the signature file.  
Things to Note - 
1. This removes ZipSigningUtility references through out the solution.
2. Moving all the packaging tests to NuGet.Packaging.FuncTests. So some of the changes are related to moving files etc.

Finally, this PR does not address the following which should be done separately - 

1. Resolve some open questions about signed package archive - NuGet/Home#6211
2. Add support for SignedPackageArchive verification if the signature is not the last entry in the zip -
 NuGet/Home#6212


## Testing/Validation
Tests Added: Yes
Validation done:  Manual validation using sign and verify commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants