Enable source-build pre-built detection #5190
Conversation
ghost
added
the
eng/SourceBuildPrebuiltBaseline.xml
Outdated
| If you get an error in source-build leg pointing at new prebuilt package being detected, | ||
| resolve the prebuilt issue before merging your PR. | ||
| If that is not possible, do the following: | ||
| - contact source-build team |
There was a problem hiding this comment.
I would include the contact info - use the dotnet/source-build-internal github team.
There was a problem hiding this comment.
Resolved in eaaaebc
eng/SourceBuildPrebuiltBaseline.xml
Outdated
| resolve the prebuilt issue before merging your PR. | ||
| If that is not possible, do the following: | ||
| - contact source-build team | ||
| - add required UsagePattern entry as provided by source-build team |
There was a problem hiding this comment.
I tend to think we should exclude anything besides resolving the prebuilt and contacting the source-build team. I fear that suggesting creating UsagePatterns is going to lead to the problem we are trying to prevent.
There was a problem hiding this comment.
Makes sense - we want source-build team to provide guidance on a case-by-case basis. Will update - thanks.
There was a problem hiding this comment.
Resolved in eaaaebc
eng/source-build/source-build.proj
Outdated
| @@ -28,7 +28,7 @@ | |||
| <Message Text="Finished restoring Arcade" Importance="High" /> | |||
|
|
|||
| <MSbuild Projects="$(ArcadeDir)/SourceBuild/AfterSourceBuild.proj" | |||
| Properties="_NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild;ArcadeBuildFromSource=true;CurrentRepoSourceBuildArtifactsPackagesDir=$(ProjectRoot)artifacts/nupkgs/" | |||
| Properties="_NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild;ArcadeBuildFromSource=true;CurrentRepoSourceBuildArtifactsPackagesDir=$(ProjectRoot)artifacts/nupkgs/;FailOnPrebuiltBaselineError=true" | |||
There was a problem hiding this comment.
Does this negatively affect the product source-build? When doing a full source-build, we don't want this repo to stop the build if it has prebuilts.
There was a problem hiding this comment.
You're right - it will affect full source-build. I think we should be able to make this change specific to repo source-build. Will update - thanks.
There was a problem hiding this comment.
Resolved in eaaaebc
eng/source-build/build.sh
Outdated
| @@ -83,4 +83,5 @@ fi | |||
|
|
|||
| ReadGlobalVersion Microsoft.DotNet.Arcade.Sdk | |||
| export ARCADE_VERSION=$_ReadGlobalVersion | |||
| export NUGET_PACKAGES=$scriptroot/../../artifacts/source-build/self/package-cache/ | |||
There was a problem hiding this comment.
Is this used/exist in the full repo source-build?
There was a problem hiding this comment.
It is set in full source-build: https://github.com/dotnet/dotnet/blob/8528c489bcbaeff232b906a3c784016f2de74fe2/build.sh#L248
I think I need to condition this for repo build only.
There was a problem hiding this comment.
Resolved in eaaaebc
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
NikolaMilosavljevic
changed the title
|
@kartheekp-ms @zivkan can this be approved for CI? This change is specific to .NET source-build. |
Done! |
There are some test failures - but since those are on Windows and this PR is only for Linux and source-build, they are unrelated. I see the same failures in other recent PRs. |
Yes those test failures are currently known and we'll ignore them. I'll just give the team one more day to review and I'll merge tomorrow. Thanks for the contribution, glad this will prevent us from breaking source build going forward. |
Bug
Fixes: NuGet/Home#12598
Regression? No
Description
Enables prebuilt detection, that causes build failure for any new prebuilts not in baseline.
Since it's not possible to flow dependencies, i.e. SBRP intermediate package, all prebuilts have to be listed in prebuilt baseline: https://github.com/NuGet/NuGet.Client/blob/dev/eng/SourceBuildPrebuiltBaseline.xml
All .NET packages are excluded with
*version, to avoid unnecessary changes in the future - i.e.:<UsagePattern IdentityGlob="System.Buffers/*" />All instances of other packages are excluded with specific version, to ensure that version update triggers proper prebuilt update process, i.e.:
<UsagePattern IdentityGlob="Newtonsoft.Json/13.0.1" />