Target net8.0 for source-build

[NikolaMilosavljevic]

Bug

Fixes: NuGet/Home#12620

Regression? No

Description

NuGet.Client needs to target net8.0 for source-build in order to eliminate all prebuilts. Source-build must build the complete dependency graph with no external dependencies. We don't allow targeting net7 or (n-1) as is would require building all of .NET 7.0 from source which would snowball.

[NikolaMilosavljevic]

@MichaelSimons @mthalman @mmitche

[NikolaMilosavljevic]

@jeffkl @zivkan can this be approved for CI?

[MichaelSimons]

@NikolaMilosavljevic - do you know why the net7.0 related prebuilts were not showing up in #5190?

[NikolaMilosavljevic]

@NikolaMilosavljevic - do you know why the net7.0 related prebuilts were not showing up in #5190?

I don't know - #5190 has all the prebuilts that were restored as part of source-build. Investigating...

[NikolaMilosavljevic]

@NikolaMilosavljevic - do you know why the net7.0 related prebuilts were not showing up in #5190?

I don't know - #5190 has all the prebuilts that were restored as part of source-build. Investigating...

@MichaelSimons which 7.0 specific prebuilts were we expecting to see in #5190?

[MichaelSimons]

@NikolaMilosavljevic - do you know why the net7.0 related prebuilts were not showing up in #5190?

I don't know - #5190 has all the prebuilts that were restored as part of source-build. Investigating...

@MichaelSimons which 7.0 specific prebuilts were we expecting to see in #5190?

Not certain but I am thinking the following:

    <Usage Id="Microsoft.AspNetCore.App.Ref" Version="7.0.5" />
    <Usage Id="Microsoft.NETCore.App.Host.linux-x64" Version="7.0.5" />
    <Usage Id="Microsoft.NETCore.App.Ref" Version="7.0.5" />

[NikolaMilosavljevic]

@NikolaMilosavljevic - do you know why the net7.0 related prebuilts were not showing up in #5190?

I don't know - #5190 has all the prebuilts that were restored as part of source-build. Investigating...

@MichaelSimons which 7.0 specific prebuilts were we expecting to see in #5190?

Not certain but I am thinking the following:

    <Usage Id="Microsoft.AspNetCore.App.Ref" Version="7.0.5" />
    <Usage Id="Microsoft.NETCore.App.Host.linux-x64" Version="7.0.5" />
    <Usage Id="Microsoft.NETCore.App.Ref" Version="7.0.5" />

I'm pretty certain that these are resolved from the restored SDK, using KnownFrameworkReference. I do not see any of these packages in binlog, artifacts folder or nuget cache.

[MichaelSimons]

I'm pretty certain that these are resolved from the restored SDK, using KnownFrameworkReference.

Agreed. Ideally we would be able to detect these. The arcade prebuilt infra does. I see this as being outside the scope of this PR regardless.

[MichaelSimons]

I think it would be good to create a source-build patch and PR so that the changes can be validated in the context of the full product build to ensure the prebuilts have been resolved.

[NikolaMilosavljevic]

I think it would be good to create a source-build patch and PR so that the changes can be validated in the context of the full product build to ensure the prebuilts have been resolved.

Yes, working on it.

[zivkan]

I'm a bit confused about all the conversation that's been going on here. I think it's orthogonal to this PR and the conversation could have been elsewhere (but something in this PR triggered the question).

Or is the conversation about something that should block the PR, so we shouldn't merge it yet?

[MichaelSimons]

I'm a bit confused about all the conversation that's been going on here. I think it's orthogonal to this PR and the conversation could have been elsewhere (but something in this PR triggered the question).

The question is why the source-build repo level prebuilt detection didn't report the .NET 7.0 targeting packages. The answer is because NuGet.Client does not utilize Arcade so the prebuilt detection infra is not as good. This is an orthogonal issue that should not block this PR. Please merge when appropriate.

[NikolaMilosavljevic]

Let's hold off with merge until we understand if additional change is needed. We are running this same change in full source-build, as part of dotnet/installer#16541. There is an error about obsolete API when compiling with Preview 4 SDK.

[NikolaMilosavljevic]

Let's hold off with merge until we understand if additional change is needed. We are running this same change in full source-build, as part of dotnet/installer#16541. There is an error about obsolete API when compiling with Preview 4 SDK.

I've created an issue to track this in nuget.client repo: NuGet/Home#12626

I am adding a workaround for full source-build: dotnet/installer@3191211

[NikolaMilosavljevic]

@jeffkl @zivkan is it possible to rerun the checks? All test failures are in machine setup steps and unrelated to any repo changes.

[jeffkl]

@jeffkl @zivkan is it possible to rerun the checks? All test failures are in machine setup steps and unrelated to any repo changes.

The End to End test failures have been fixed but you'll need to rebase. Ping me when you've pushed and I can start the CI.

[NikolaMilosavljevic]

@jeffkl @zivkan is it possible to rerun the checks? All test failures are in machine setup steps and unrelated to any repo changes.

The End to End test failures have been fixed but you'll need to rebase. Ping me when you've pushed and I can start the CI.

Tried to rebase with 'close/reopen' but that doesn't seem to work in this repo.

@jeffkl I've pushed the rebased changes.