Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Short names must be one char. Pick new ones. #668

Merged
merged 8 commits into from
Jan 31, 2019

Conversation

AnthonySteele
Copy link
Member

@AnthonySteele AnthonySteele commented Jan 27, 2019

With the latest CommandlineUtils, option short names must be one char (as intended). The 2-char short
names don't work any more.

This is a breaking change, but it is already broken.

In this PR, each option has a unique short name. Since there are 22 of them, many are unrelated to the command text.
And we are running out of letters. Some future options won't have short names.

In this new scheme, some of the options don't have short names at all where they are 1) not frequently used and 2) no obvious letter is available.

Copy link
Collaborator

@skolima skolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Like the new aliases for commands.

@AnthonySteele
Copy link
Member Author

AnthonySteele commented Jan 29, 2019

Now is a good time to revisit MaxPr .

internally this is called MaxPackageUpdates as this more accurately reflects what it now does.
If you're running in repo mode with one PR per package updated, then it is the number of PRs. Otherwise it's just a cap on the number of package updates.

This has caused confusion, and renaming has been suggested previously. Now is a good time to change this. Maybe to MaxUpdates or MaxPackageUpdates ?

@skolima
Copy link
Collaborator

skolima commented Jan 29, 2019

Seems like MaxPackageUpdates is the name to use then. Perhaps something to suggest it's a per-repository limit?

@AnthonySteele AnthonySteele merged commit e9764f3 into NuKeeperDotNet:master Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants