This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Short names must be one char. Pick new ones. #668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest
CommandlineUtils
, option short names must be one char (as intended). The 2-char shortnames don't work any more.
This is a breaking change, but it is already broken.
In this PR, each option has a unique short name. Since there are 22 of them, many are unrelated to the command text.
And we are running out of letters. Some future options won't have short names.
In this new scheme, some of the options don't have short names at all where they are 1) not frequently used and 2) no obvious letter is available.