Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conex output pull request #90

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conex output pull request #90

wants to merge 13 commits into from

Conversation

Jorgecvb1
Copy link

@Jorgecvb1 Jorgecvb1 commented Sep 25, 2023

Implementation of the possibility to have a conex-like output of the nuspace simulation as .root file.
If is set to 1 in the xml input file, the eas part of the simulation will be writing the slant depth, height and number of particles profiles to a file, which will then be read by the conex_out.py module. This module will read this data together with other data from the results tables, perform a Gaisser-Hillas 6-parameter fit, and write all the relevant information to a .root file following the output format of Conex 2.51.

It adds a dependency to uproot.

@Jorgecvb1 Jorgecvb1 added the enhancement New feature or request label Sep 25, 2023
@Jorgecvb1 Jorgecvb1 self-assigned this Sep 25, 2023
@Jorgecvb1 Jorgecvb1 marked this pull request as draft September 25, 2023 15:57
@Areustle Areustle self-assigned this Sep 25, 2023
@Jorgecvb1 Jorgecvb1 marked this pull request as ready for review September 26, 2023 17:51
@Areustle
Copy link
Contributor

Areustle commented Oct 5, 2023

Okay I've looked this over and I think it's good, but will require some alterations.

  • - The conexoutput config option should be a commandline flag as well.
  • - Before going to release, should transition away from the showerdata.csv file mechanism. Writing the data to disk in parallel is error-prone, due to data-race conditions. Can also cause performance slowdowns and bugs if the layers & events are written out-of-order. Should rewrite the EAS cphotang functions to build up and return variable-length arrays, probably with awkward.
  • - Write the variable length arrays out to the sim Results table object using the existing support functions here: https://docs.astropy.org/en/stable/io/fits/usage/unfamiliar.html#variable-length-array-tables
  • - Finally, write the conex output uproot file by reading from the sim table, rather than the showerdata.csv file.

Good work and a good use of both uproot and awkward array, which I wasn't familiar with before 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting EAS profile information for direct read-in by any UV sensitive experiment
2 participants