small refactoring for lib/settings & add forgotten .format() to main.py #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menkar3
commented
Mar 1, 2018
| @@ -13,21 +13,22 @@ | |||
| import lib.output | |||
| import lib.banner | |||
|
|
|||
| CUR_DIR = "{}".format(os.getcwd()) | |||
There was a problem hiding this comment.
One variable, or ten more function calls.
There was a problem hiding this comment.
I mean it's not much different, but I see where you're coming from
menkar3
commented
Mar 1, 2018
| make the directory if it does not exist | ||
| """ | ||
| if not os.path.exists(dir): | ||
| os.mkdir(dir) |
There was a problem hiding this comment.
I think, two small lines will be better than one-time call of locally defined function (in case of optimization too).
There was a problem hiding this comment.
Okay I see what you did, change the variable to path so it doesn't overwrite the built in dir var
Ekultek
reviewed
Mar 1, 2018
| @@ -200,8 +192,10 @@ def animation(text): | |||
| global stop_animation | |||
| i = 0 | |||
| while not stop_animation: | |||
| """ | |||
There was a problem hiding this comment.
You realize that in order to stop the animation, I have to print a new line character otherwise it does an endless cycle
Ekultek
suggested changes
Mar 1, 2018
|
I'll merge this into dev-beta, and then add it to master as a quick hotfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.