Skip to content

feat(AGI-162): compare severities quantitatively #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2024
Merged

feat(AGI-162): compare severities quantitatively #145

merged 1 commit into from
Nov 11, 2024

Conversation

juicetin
Copy link
Contributor

@juicetin juicetin commented Nov 11, 2024 •
edited
Loading

Description

allow severity comparisons like if CompareSeverity(cve.Severity, configmodels.HighSeverity) >= 0

Test Plan

  • covered by unit tests

Linked Issues & PRs

  • resolves
  • relates to

GitHub Issue Linking Docs

Checklist

  • I have added one of the patch, minor, major or no-release labels
  • I have linked an issue from this repository using the Development option
  • I have performed a self-review of my own code
  • I have checked for redundant or commented out code
  • I have commented my code where I can't make it self-documenting
  • I have made corresponding changes to the documentation
  • I have added any appropriate tests

@juicetin juicetin added the patch label Nov 11, 2024
@juicetin juicetin self-assigned this Nov 11, 2024
@juicetin juicetin marked this pull request as ready for review November 11, 2024 00:55
@juicetin juicetin added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 9bdcf22 Nov 11, 2024
7 checks passed
@juicetin juicetin deleted the feat/AGI-162 branch November 11, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-thacker-nullify tim-thacker-nullify tim-thacker-nullify approved these changes

@nalbion nalbion Awaiting requested review from nalbion

@jonathanlam jonathanlam Awaiting requested review from jonathanlam

Assignees

@juicetin juicetin

Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juicetin @tim-thacker-nullify