net: npcm7xx: EMAC driver should not directly use seq_read.

[kunyi731]

Procfs read should be npcm7xx_proc_read function so that the read
operation correctly allocates dump memory.

Change-Id: I2bd72fbc5c1668c062c6eb5b95057c7f050b6009
Signed-off-by: Kun Yi kunyi@google.com

[avifishman]

Hi Kun, Did you try to do "cat /proc/driver/npcm7xx_emc.0" after th echange and is it working well? Avi

…

On Mon, Jun 18, 2018 at 8:32 AM Kun Yi ***@***.***> wrote: Procfs read should be npcm7xx_proc_read function so that the read operation correctly allocates dump memory. Change-Id: I2bd72fbc5c1668c062c6eb5b95057c7f050b6009 Signed-off-by: Kun Yi ***@***.*** ------------------------------ You can view, comment on, or merge this pull request online at: #8 Commit Summary - net: npcm7xx: EMAC driver should not directly use seq_read. File Changes - *M* drivers/net/ethernet/nuvoton/npcm7xx_emc.c <https://github.com/Nuvoton-Israel/linux/pull/8/files#diff-0> (4) Patch Links: - https://github.com/Nuvoton-Israel/linux/pull/8.patch - https://github.com/Nuvoton-Israel/linux/pull/8.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#8>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AbbZSra6QF3eaQoQq5UUF_YC10d8DTu7ks5t9ztQgaJpZM4UrLMn> .

[kunyi731]

Yes I did. Example output: root@arcadia:~# cat /proc/driver/npcm7xx_emc.0 NPCM7XX EMC eth0 driver version: 3.90 REG_CAMCMR = 00000016 REG_CAMEN = 00000001 REG_CAMM_BASE = A6DCABA6 REG_CAML_BASE = 44480000 REG_TXDLSA = 3B47B000 REG_RXDLSA = 36B99000 REG_MCMDR = 0008032B REG_MIID = 00000000 REG_MIIDA = 00900000 REG_FFTCR = 00200203 REG_TSDR = FFFFFFFF REG_RSDR = FFFFFFFF REG_DMARFC = 000005F2 REG_MIEN = 017F0DF7 REG_MISTA = 00800000 REG_MGSTA = 00000000 REG_MPCNT = 00007FFF REG_MRPC = 00000000 REG_MRPCC = 00000000 REG_MREPC = 00000000 REG_DMARFS = 00000000 REG_CTXDSA = 3B47B2C0 REG_CTXBSA = 3AEA6800 REG_CRXDSA = 36B99000 REG_CRXBSA = 3B6A7940 REG_RXFSM = 04012102 REG_TXFSM = 80012101 REG_FSM0 = 00010101 REG_FSM1 = 01000000 REG_DCR = 0000003F REG_DMMIR = 00000000 REG_BISTR = 00000000 netif_queue Running napi is not scheduled TXD offset 44 cur_tx 44 finish_tx 43 pending_tx 1 tx_tdu 0 tx_tdu_i 0 tx_cp_i 0 tx_int_count 0 count_xmit tx 77 count_finish 75 RXD offset 0 cur_rx 0 rx_err 0 rx_berr 0 rx_stuck 0 rdu 0 rxov rx 0 rx_int_count 0 rx_err_count 0 rx_count_pool 0 max_waiting_rx 0 need_reset 0 finish 42 txbd mode 00000003 buffer 3AE49C02 sl 00290227 next 3B47B2B0 tx_skb (null) finish 43 txbd mode 00000003 buffer 3AEA6802 sl 00290200 next 3B47B2C0 tx_skb eb40f780 finish 44 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B2D0 tx_skb (null) txd_of 43 txbd mode 00000003 buffer 3AEA6802 sl 00290200 next 3B47B2C0 txd_of 44 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B2D0 txd_of 45 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B2E0 cur_tx 46 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B2F0 cur_tx 47 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B300 cur_tx 48 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B310 cur_tx 49 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B320 cur_tx 50 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B330 cur_tx 51 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B340 cur_tx 52 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B350 cur_tx 53 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B360 cur_tx 54 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B370 cur_tx 55 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B380 cur_tx 56 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B390 cur_tx 57 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B3A0 cur_tx 58 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B3B0 cur_tx 59 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B3C0 cur_tx 60 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B3D0 cur_tx 61 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B3E0 cur_tx 62 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B3F0 cur_tx 63 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B000 cur_tx 0 txbd mode 00000003 buffer 3AEA9002 sl 0029005A next 3B47B010 cur_tx 1 txbd mode 00000003 buffer 3AEC0802 sl 0029005A next 3B47B020 cur_tx 2 txbd mode 00000003 buffer 3AE24402 sl 0029002A next 3B47B030 cur_tx 3 txbd mode 00000003 buffer 3B421802 sl 00290056 next 3B47B040 cur_tx 4 txbd mode 00000003 buffer 3AEA9002 sl 0029005A next 3B47B050 cur_tx 5 txbd mode 00000003 buffer 3AEC0802 sl 0029005A next 3B47B060 cur_tx 6 txbd mode 00000003 buffer 3AE59C0A sl 00290208 next 3B47B070 cur_tx 7 txbd mode 00000003 buffer 3AE4A00A sl 00290162 next 3B47B080 cur_tx 8 txbd mode 00000003 buffer 3AE59C0A sl 00290208 next 3B47B090 cur_tx 9 txbd mode 00000003 buffer 3B55A802 sl 0029006E next 3B47B0A0 cur_tx 10 txbd mode 00000003 buffer 3AE4A00A sl 00290208 next 3B47B0B0 cur_tx 11 txbd mode 00000003 buffer 3B55A802 sl 0029005A next 3B47B0C0 cur_tx 12 txbd mode 00000003 buffer 3AE4A00A sl 002901DE next 3B47B0D0 cur_tx 13 txbd mode 00000003 buffer 3AE24302 sl 0029002A next 3B47B0E0 cur_tx 14 txbd mode 00000003 buffer 3AE4A00A sl 0029022B next 3B47B0F0 cur_tx 15 txbd mode 00000003 buffer 3C10140A sl 002901DE next 3B47B100 cur_tx 16 txbd mode 00000003 buffer 3AE24302 sl 0029002A next 3B47B110 cur_tx 17 txbd mode 00000003 buffer 3C10140A sl 0029022B next 3B47B120 cur_tx 18 txbd mode 00000003 buffer 3AE4A00A sl 002901DE next 3B47B130 cur_tx 19 txbd mode 00000003 buffer 3AE24D02 sl 0029002A next 3B47B140 cur_tx 20 txbd mode 00000003 buffer 3B4EA802 sl 00290230 next 3B47B150 cur_tx 21 txbd mode 00000003 buffer 3B477002 sl 0029014E next 3B47B160 cur_tx 22 txbd mode 00000003 buffer 3B4EA802 sl 00290230 next 3B47B170 cur_tx 23 txbd mode 00000003 buffer 3B477002 sl 00290230 next 3B47B180 cur_tx 24 txbd mode 00000003 buffer 3B4EA802 sl 00290200 next 3B47B190 cur_tx 25 txbd mode 00000003 buffer 3B477002 sl 00290227 next 3B47B1A0 cur_tx 26 txbd mode 00000003 buffer 3B4EA802 sl 00290200 next 3B47B1B0 cur_tx 27 txbd mode 00000003 buffer 3AE24D02 sl 0029002A next 3B47B1C0 cur_tx 28 txbd mode 00000003 buffer 3B4EA802 sl 00290227 next 3B47B1D0 cur_tx 29 txbd mode 00000003 buffer 3B477002 sl 00290200 next 3B47B1E0 cur_tx 30 txbd mode 00000003 buffer 3AF81E02 sl 0029002A next 3B47B1F0 cur_tx 31 txbd mode 00000003 buffer 3ADD1702 sl 0029002A next 3B47B200 cur_tx 32 txbd mode 00000003 buffer 3AF81E02 sl 0029002A next 3B47B210 cur_tx 33 txbd mode 00000003 buffer 3ADD1702 sl 0029002A next 3B47B220 cur_tx 34 txbd mode 00000003 buffer 3AEF2802 sl 00290230 next 3B47B230 cur_tx 35 txbd mode 00000003 buffer 3AEA6802 sl 0029014E next 3B47B240 cur_tx 36 txbd mode 00000003 buffer 3AEF2802 sl 00290230 next 3B47B250 cur_tx 37 txbd mode 00000003 buffer 3AEA6802 sl 00290230 next 3B47B260 cur_tx 38 txbd mode 00000003 buffer 3AEF2802 sl 00290200 next 3B47B270 cur_tx 39 txbd mode 00000003 buffer 3AEA6802 sl 0029014E next 3B47B280 cur_tx 40 txbd mode 00000003 buffer 3AEF2802 sl 00290200 next 3B47B290 cur_tx 41 txbd mode 00000003 buffer 3B4BB002 sl 0029002A next 3B47B2A0 cur_tx 42 txbd mode 00000003 buffer 3AE49C02 sl 00290227 next 3B47B2B0 cur_tx 43 txbd mode 00000003 buffer 3AEA6802 sl 00290200 next 3B47B2C0 cur_tx 44 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B2D0 cur_tx 45 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B2E0 cur_rx 66 rxbd sl 80000000 buffer 3B672540 sl 00000000 next 36B99430 cur_rx 67 rxbd sl 80000000 buffer 3B671E40 sl 00000000 next 36B99440 cur_rx 68 rxbd sl 80000000 buffer 3B671740 sl 00000000 next 36B99450 cur_rx 69 rxbd sl 80000000 buffer 3B671040 sl 00000000 next 36B99460 cur_rx 70 rxbd sl 80000000 buffer 3B670940 sl 00000000 next 36B99470 cur_rx 71 rxbd sl 80000000 buffer 3B670240 sl 00000000 next 36B99480 cur_rx 72 rxbd sl 80000000 buffer 3B67F940 sl 00000000 next 36B99490 cur_rx 73 rxbd sl 80000000 buffer 3B67F240 sl 00000000 next 36B994A0 cur_rx 74 rxbd sl 80000000 buffer 3B67EB40 sl 00000000 next 36B994B0 cur_rx 75 rxbd sl 80000000 buffer 3B67E440 sl 00000000 next 36B994C0 cur_rx 76 rxbd sl 80000000 buffer 3B67DD40 sl 00000000 next 36B994D0 cur_rx 77 rxbd sl 80000000 buffer 3B67D640 sl 00000000 next 36B994E0 cur_rx 78 rxbd sl 80000000 buffer 3B67CF40 sl 00000000 next 36B994F0 cur_rx 79 rxbd sl 80000000 buffer 3B67C840 sl 00000000 next 36B99500 cur_rx 80 rxbd sl 80000000 buffer 3B67C140 sl 00000000 next 36B99510 cur_rx 81 rxbd sl 80000000 buffer 3B67BA40 sl 00000000 next 36B99520 cur_rx 82 rxbd sl 80000000 buffer 3B67B340 sl 00000000 next 36B99530 cur_rx 83 rxbd sl 80000000 buffer 3B67AC40 sl 00000000 next 36B99540 cur_rx 84 rxbd sl 80000000 buffer 3B67A540 sl 00000000 next 36B99550 cur_rx 85 rxbd sl 80000000 buffer 3B679E40 sl 00000000 next 36B99560 cur_rx 86 rxbd sl 80000000 buffer 3B679740 sl 00000000 next 36B99570 cur_rx 87 rxbd sl 80000000 buffer 3B679040 sl 00000000 next 36B99580 cur_rx 88 rxbd sl 80000000 buffer 3B678940 sl 00000000 next 36B99590 cur_rx 89 rxbd sl 80000000 buffer 3B678240 sl 00000000 next 36B995A0 cur_rx 90 rxbd sl 80000000 buffer 3B757940 sl 00000000 next 36B995B0 cur_rx 91 rxbd sl 80000000 buffer 3B757240 sl 00000000 next 36B995C0 cur_rx 92 rxbd sl 80000000 buffer 3B756B40 sl 00000000 next 36B995D0 cur_rx 93 rxbd sl 80000000 buffer 3B756440 sl 00000000 next 36B995E0 cur_rx 94 rxbd sl 80000000 buffer 3B755D40 sl 00000000 next 36B995F0 cur_rx 95 rxbd sl 80000000 buffer 3B755640 sl 00000000 next 36B99600 cur_rx 96 rxbd sl 80000000 buffer 3B754F40 sl 00000000 next 36B99610 cur_rx 97 rxbd sl 80000000 buffer 3B754840 sl 00000000 next 36B99620 cur_rx 98 rxbd sl 80000000 buffer 3B754140 sl 00000000 next 36B99630 cur_rx 99 rxbd sl 80000000 buffer 3B753A40 sl 00000000 next 36B99640 cur_rx 100 rxbd sl 80000000 buffer 3B753340 sl 00000000 next 36B99650 cur_rx 101 rxbd sl 80000000 buffer 3B752C40 sl 00000000 next 36B99660 cur_rx 102 rxbd sl 80000000 buffer 3B752540 sl 00000000 next 36B99670 cur_rx 103 rxbd sl 80000000 buffer 3B751E40 sl 00000000 next 36B99680 cur_rx 104 rxbd sl 80000000 buffer 3B751740 sl 00000000 next 36B99690 cur_rx 105 rxbd sl 80000000 buffer 3B751040 sl 00000000 next 36B996A0 cur_rx 106 rxbd sl 80000000 buffer 3B750940 sl 00000000 next 36B996B0 cur_rx 107 rxbd sl 80000000 buffer 3B750240 sl 00000000 next 36B996C0 cur_rx 108 rxbd sl 80000000 buffer 3B75F940 sl 00000000 next 36B996D0 cur_rx 109 rxbd sl 80000000 buffer 3B75F240 sl 00000000 next 36B996E0 cur_rx 110 rxbd sl 80000000 buffer 3B75EB40 sl 00000000 next 36B996F0 cur_rx 111 rxbd sl 80000000 buffer 3B75E440 sl 00000000 next 36B99700 cur_rx 112 rxbd sl 80000000 buffer 3B75DD40 sl 00000000 next 36B99710 cur_rx 113 rxbd sl 80000000 buffer 3B75D640 sl 00000000 next 36B99720 cur_rx 114 rxbd sl 80000000 buffer 3B75CF40 sl 00000000 next 36B99730 cur_rx 115 rxbd sl 80000000 buffer 3B75C840 sl 00000000 next 36B99740 cur_rx 116 rxbd sl 80000000 buffer 3B75C140 sl 00000000 next 36B99750 cur_rx 117 rxbd sl 80000000 buffer 3B75BA40 sl 00000000 next 36B99760 cur_rx 118 rxbd sl 80000000 buffer 3B75B340 sl 00000000 next 36B99770 cur_rx 119 rxbd sl 80000000 buffer 3B75AC40 sl 00000000 next 36B99780 cur_rx 120 rxbd sl 80000000 buffer 3B75A540 sl 00000000 next 36B99790 cur_rx 121 rxbd sl 80000000 buffer 3B759E40 sl 00000000 next 36B997A0 cur_rx 122 rxbd sl 80000000 buffer 3B759740 sl 00000000 next 36B997B0 cur_rx 123 rxbd sl 80000000 buffer 3B759040 sl 00000000 next 36B997C0 cur_rx 124 rxbd sl 80000000 buffer 3B758940 sl 00000000 next 36B997D0 cur_rx 125 rxbd sl 80000000 buffer 3B758240 sl 00000000 next 36B997E0 cur_rx 126 rxbd sl 80000000 buffer 3B687940 sl 00000000 next 36B997F0 cur_rx 127 rxbd sl 80000000 buffer 3B687240 sl 00000000 next 36B99000 cur_rx 0 rxbd sl 80000000 buffer 3B6A7940 sl 00000000 next 36B99010 cur_rx 1 rxbd sl 80000000 buffer 3B6A7240 sl 00000000 next 36B99020 rxd_of 127 rxbd sl 80000000 buffer 3B687240 sl 00000000 next 36B99000 rxd_of 0 rxbd sl 80000000 buffer 3B6A7940 sl 00000000 next 36B99010 rxd_of 1 rxbd sl 80000000 buffer 3B6A7240 sl 00000000 next 36B99020 root@arcadia:~# Still working on verifying NC-SI with the EMAC driver on our board, but what I found is that using seq_read will crash the kernel. So this is a patch just to get unblocked. Thanks, Kun On Mon, Jun 18, 2018 at 4:10 AM Avi Fishman <notifications@github.com> wrote:

…

Hi Kun, Did you try to do "cat /proc/driver/npcm7xx_emc.0" after th echange and is it working well? Avi On Mon, Jun 18, 2018 at 8:32 AM Kun Yi ***@***.***> wrote: > Procfs read should be npcm7xx_proc_read function so that the read > operation correctly allocates dump memory. > > Change-Id: I2bd72fbc5c1668c062c6eb5b95057c7f050b6009 > Signed-off-by: Kun Yi ***@***.*** > ------------------------------ > You can view, comment on, or merge this pull request online at: > > #8 > Commit Summary > > - net: npcm7xx: EMAC driver should not directly use seq_read. > > File Changes > > - *M* drivers/net/ethernet/nuvoton/npcm7xx_emc.c > <https://github.com/Nuvoton-Israel/linux/pull/8/files#diff-0> (4) > > Patch Links: > > - https://github.com/Nuvoton-Israel/linux/pull/8.patch > - https://github.com/Nuvoton-Israel/linux/pull/8.diff > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#8>, or mute the thread > < https://github.com/notifications/unsubscribe-auth/AbbZSra6QF3eaQoQq5UUF_YC10d8DTu7ks5t9ztQgaJpZM4UrLMn > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB9Sx6dIJPSubZuHBusLnXy7fZrPlZc5ks5t94qKgaJpZM4UrLMn> .

-- Regards, Kun

[avifishman]

I tried your change and it crashes since in npcm7xx_proc_read(): struct net_device *dev = (struct net_device *)sf->private; 'dev' gets NULL. Have you done other changes?

…

On Mon, Jun 18, 2018 at 5:32 PM Kun Yi ***@***.***> wrote: Yes I did. Example output: ***@***.***:~# cat /proc/driver/npcm7xx_emc.0 NPCM7XX EMC eth0 driver version: 3.90 REG_CAMCMR = 00000016 REG_CAMEN = 00000001 REG_CAMM_BASE = A6DCABA6 REG_CAML_BASE = 44480000 REG_TXDLSA = 3B47B000 REG_RXDLSA = 36B99000 REG_MCMDR = 0008032B REG_MIID = 00000000 REG_MIIDA = 00900000 REG_FFTCR = 00200203 REG_TSDR = FFFFFFFF REG_RSDR = FFFFFFFF REG_DMARFC = 000005F2 REG_MIEN = 017F0DF7 REG_MISTA = 00800000 REG_MGSTA = 00000000 REG_MPCNT = 00007FFF REG_MRPC = 00000000 REG_MRPCC = 00000000 REG_MREPC = 00000000 REG_DMARFS = 00000000 REG_CTXDSA = 3B47B2C0 REG_CTXBSA = 3AEA6800 REG_CRXDSA = 36B99000 REG_CRXBSA = 3B6A7940 REG_RXFSM = 04012102 REG_TXFSM = 80012101 REG_FSM0 = 00010101 REG_FSM1 = 01000000 REG_DCR = 0000003F REG_DMMIR = 00000000 REG_BISTR = 00000000 netif_queue Running napi is not scheduled TXD offset 44 cur_tx 44 finish_tx 43 pending_tx 1 tx_tdu 0 tx_tdu_i 0 tx_cp_i 0 tx_int_count 0 count_xmit tx 77 count_finish 75 RXD offset 0 cur_rx 0 rx_err 0 rx_berr 0 rx_stuck 0 rdu 0 rxov rx 0 rx_int_count 0 rx_err_count 0 rx_count_pool 0 max_waiting_rx 0 need_reset 0 finish 42 txbd mode 00000003 buffer 3AE49C02 sl 00290227 next 3B47B2B0 tx_skb (null) finish 43 txbd mode 00000003 buffer 3AEA6802 sl 00290200 next 3B47B2C0 tx_skb eb40f780 finish 44 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B2D0 tx_skb (null) txd_of 43 txbd mode 00000003 buffer 3AEA6802 sl 00290200 next 3B47B2C0 txd_of 44 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B2D0 txd_of 45 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B2E0 cur_tx 46 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B2F0 cur_tx 47 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B300 cur_tx 48 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B310 cur_tx 49 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B320 cur_tx 50 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B330 cur_tx 51 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B340 cur_tx 52 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B350 cur_tx 53 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B360 cur_tx 54 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B370 cur_tx 55 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B380 cur_tx 56 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B390 cur_tx 57 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B3A0 cur_tx 58 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B3B0 cur_tx 59 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B3C0 cur_tx 60 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B3D0 cur_tx 61 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B3E0 cur_tx 62 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B3F0 cur_tx 63 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B000 cur_tx 0 txbd mode 00000003 buffer 3AEA9002 sl 0029005A next 3B47B010 cur_tx 1 txbd mode 00000003 buffer 3AEC0802 sl 0029005A next 3B47B020 cur_tx 2 txbd mode 00000003 buffer 3AE24402 sl 0029002A next 3B47B030 cur_tx 3 txbd mode 00000003 buffer 3B421802 sl 00290056 next 3B47B040 cur_tx 4 txbd mode 00000003 buffer 3AEA9002 sl 0029005A next 3B47B050 cur_tx 5 txbd mode 00000003 buffer 3AEC0802 sl 0029005A next 3B47B060 cur_tx 6 txbd mode 00000003 buffer 3AE59C0A sl 00290208 next 3B47B070 cur_tx 7 txbd mode 00000003 buffer 3AE4A00A sl 00290162 next 3B47B080 cur_tx 8 txbd mode 00000003 buffer 3AE59C0A sl 00290208 next 3B47B090 cur_tx 9 txbd mode 00000003 buffer 3B55A802 sl 0029006E next 3B47B0A0 cur_tx 10 txbd mode 00000003 buffer 3AE4A00A sl 00290208 next 3B47B0B0 cur_tx 11 txbd mode 00000003 buffer 3B55A802 sl 0029005A next 3B47B0C0 cur_tx 12 txbd mode 00000003 buffer 3AE4A00A sl 002901DE next 3B47B0D0 cur_tx 13 txbd mode 00000003 buffer 3AE24302 sl 0029002A next 3B47B0E0 cur_tx 14 txbd mode 00000003 buffer 3AE4A00A sl 0029022B next 3B47B0F0 cur_tx 15 txbd mode 00000003 buffer 3C10140A sl 002901DE next 3B47B100 cur_tx 16 txbd mode 00000003 buffer 3AE24302 sl 0029002A next 3B47B110 cur_tx 17 txbd mode 00000003 buffer 3C10140A sl 0029022B next 3B47B120 cur_tx 18 txbd mode 00000003 buffer 3AE4A00A sl 002901DE next 3B47B130 cur_tx 19 txbd mode 00000003 buffer 3AE24D02 sl 0029002A next 3B47B140 cur_tx 20 txbd mode 00000003 buffer 3B4EA802 sl 00290230 next 3B47B150 cur_tx 21 txbd mode 00000003 buffer 3B477002 sl 0029014E next 3B47B160 cur_tx 22 txbd mode 00000003 buffer 3B4EA802 sl 00290230 next 3B47B170 cur_tx 23 txbd mode 00000003 buffer 3B477002 sl 00290230 next 3B47B180 cur_tx 24 txbd mode 00000003 buffer 3B4EA802 sl 00290200 next 3B47B190 cur_tx 25 txbd mode 00000003 buffer 3B477002 sl 00290227 next 3B47B1A0 cur_tx 26 txbd mode 00000003 buffer 3B4EA802 sl 00290200 next 3B47B1B0 cur_tx 27 txbd mode 00000003 buffer 3AE24D02 sl 0029002A next 3B47B1C0 cur_tx 28 txbd mode 00000003 buffer 3B4EA802 sl 00290227 next 3B47B1D0 cur_tx 29 txbd mode 00000003 buffer 3B477002 sl 00290200 next 3B47B1E0 cur_tx 30 txbd mode 00000003 buffer 3AF81E02 sl 0029002A next 3B47B1F0 cur_tx 31 txbd mode 00000003 buffer 3ADD1702 sl 0029002A next 3B47B200 cur_tx 32 txbd mode 00000003 buffer 3AF81E02 sl 0029002A next 3B47B210 cur_tx 33 txbd mode 00000003 buffer 3ADD1702 sl 0029002A next 3B47B220 cur_tx 34 txbd mode 00000003 buffer 3AEF2802 sl 00290230 next 3B47B230 cur_tx 35 txbd mode 00000003 buffer 3AEA6802 sl 0029014E next 3B47B240 cur_tx 36 txbd mode 00000003 buffer 3AEF2802 sl 00290230 next 3B47B250 cur_tx 37 txbd mode 00000003 buffer 3AEA6802 sl 00290230 next 3B47B260 cur_tx 38 txbd mode 00000003 buffer 3AEF2802 sl 00290200 next 3B47B270 cur_tx 39 txbd mode 00000003 buffer 3AEA6802 sl 0029014E next 3B47B280 cur_tx 40 txbd mode 00000003 buffer 3AEF2802 sl 00290200 next 3B47B290 cur_tx 41 txbd mode 00000003 buffer 3B4BB002 sl 0029002A next 3B47B2A0 cur_tx 42 txbd mode 00000003 buffer 3AE49C02 sl 00290227 next 3B47B2B0 cur_tx 43 txbd mode 00000003 buffer 3AEA6802 sl 00290200 next 3B47B2C0 cur_tx 44 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B2D0 cur_tx 45 txbd mode 00000000 buffer 00000000 sl 00000000 next 3B47B2E0 cur_rx 66 rxbd sl 80000000 buffer 3B672540 sl 00000000 next 36B99430 cur_rx 67 rxbd sl 80000000 buffer 3B671E40 sl 00000000 next 36B99440 cur_rx 68 rxbd sl 80000000 buffer 3B671740 sl 00000000 next 36B99450 cur_rx 69 rxbd sl 80000000 buffer 3B671040 sl 00000000 next 36B99460 cur_rx 70 rxbd sl 80000000 buffer 3B670940 sl 00000000 next 36B99470 cur_rx 71 rxbd sl 80000000 buffer 3B670240 sl 00000000 next 36B99480 cur_rx 72 rxbd sl 80000000 buffer 3B67F940 sl 00000000 next 36B99490 cur_rx 73 rxbd sl 80000000 buffer 3B67F240 sl 00000000 next 36B994A0 cur_rx 74 rxbd sl 80000000 buffer 3B67EB40 sl 00000000 next 36B994B0 cur_rx 75 rxbd sl 80000000 buffer 3B67E440 sl 00000000 next 36B994C0 cur_rx 76 rxbd sl 80000000 buffer 3B67DD40 sl 00000000 next 36B994D0 cur_rx 77 rxbd sl 80000000 buffer 3B67D640 sl 00000000 next 36B994E0 cur_rx 78 rxbd sl 80000000 buffer 3B67CF40 sl 00000000 next 36B994F0 cur_rx 79 rxbd sl 80000000 buffer 3B67C840 sl 00000000 next 36B99500 cur_rx 80 rxbd sl 80000000 buffer 3B67C140 sl 00000000 next 36B99510 cur_rx 81 rxbd sl 80000000 buffer 3B67BA40 sl 00000000 next 36B99520 cur_rx 82 rxbd sl 80000000 buffer 3B67B340 sl 00000000 next 36B99530 cur_rx 83 rxbd sl 80000000 buffer 3B67AC40 sl 00000000 next 36B99540 cur_rx 84 rxbd sl 80000000 buffer 3B67A540 sl 00000000 next 36B99550 cur_rx 85 rxbd sl 80000000 buffer 3B679E40 sl 00000000 next 36B99560 cur_rx 86 rxbd sl 80000000 buffer 3B679740 sl 00000000 next 36B99570 cur_rx 87 rxbd sl 80000000 buffer 3B679040 sl 00000000 next 36B99580 cur_rx 88 rxbd sl 80000000 buffer 3B678940 sl 00000000 next 36B99590 cur_rx 89 rxbd sl 80000000 buffer 3B678240 sl 00000000 next 36B995A0 cur_rx 90 rxbd sl 80000000 buffer 3B757940 sl 00000000 next 36B995B0 cur_rx 91 rxbd sl 80000000 buffer 3B757240 sl 00000000 next 36B995C0 cur_rx 92 rxbd sl 80000000 buffer 3B756B40 sl 00000000 next 36B995D0 cur_rx 93 rxbd sl 80000000 buffer 3B756440 sl 00000000 next 36B995E0 cur_rx 94 rxbd sl 80000000 buffer 3B755D40 sl 00000000 next 36B995F0 cur_rx 95 rxbd sl 80000000 buffer 3B755640 sl 00000000 next 36B99600 cur_rx 96 rxbd sl 80000000 buffer 3B754F40 sl 00000000 next 36B99610 cur_rx 97 rxbd sl 80000000 buffer 3B754840 sl 00000000 next 36B99620 cur_rx 98 rxbd sl 80000000 buffer 3B754140 sl 00000000 next 36B99630 cur_rx 99 rxbd sl 80000000 buffer 3B753A40 sl 00000000 next 36B99640 cur_rx 100 rxbd sl 80000000 buffer 3B753340 sl 00000000 next 36B99650 cur_rx 101 rxbd sl 80000000 buffer 3B752C40 sl 00000000 next 36B99660 cur_rx 102 rxbd sl 80000000 buffer 3B752540 sl 00000000 next 36B99670 cur_rx 103 rxbd sl 80000000 buffer 3B751E40 sl 00000000 next 36B99680 cur_rx 104 rxbd sl 80000000 buffer 3B751740 sl 00000000 next 36B99690 cur_rx 105 rxbd sl 80000000 buffer 3B751040 sl 00000000 next 36B996A0 cur_rx 106 rxbd sl 80000000 buffer 3B750940 sl 00000000 next 36B996B0 cur_rx 107 rxbd sl 80000000 buffer 3B750240 sl 00000000 next 36B996C0 cur_rx 108 rxbd sl 80000000 buffer 3B75F940 sl 00000000 next 36B996D0 cur_rx 109 rxbd sl 80000000 buffer 3B75F240 sl 00000000 next 36B996E0 cur_rx 110 rxbd sl 80000000 buffer 3B75EB40 sl 00000000 next 36B996F0 cur_rx 111 rxbd sl 80000000 buffer 3B75E440 sl 00000000 next 36B99700 cur_rx 112 rxbd sl 80000000 buffer 3B75DD40 sl 00000000 next 36B99710 cur_rx 113 rxbd sl 80000000 buffer 3B75D640 sl 00000000 next 36B99720 cur_rx 114 rxbd sl 80000000 buffer 3B75CF40 sl 00000000 next 36B99730 cur_rx 115 rxbd sl 80000000 buffer 3B75C840 sl 00000000 next 36B99740 cur_rx 116 rxbd sl 80000000 buffer 3B75C140 sl 00000000 next 36B99750 cur_rx 117 rxbd sl 80000000 buffer 3B75BA40 sl 00000000 next 36B99760 cur_rx 118 rxbd sl 80000000 buffer 3B75B340 sl 00000000 next 36B99770 cur_rx 119 rxbd sl 80000000 buffer 3B75AC40 sl 00000000 next 36B99780 cur_rx 120 rxbd sl 80000000 buffer 3B75A540 sl 00000000 next 36B99790 cur_rx 121 rxbd sl 80000000 buffer 3B759E40 sl 00000000 next 36B997A0 cur_rx 122 rxbd sl 80000000 buffer 3B759740 sl 00000000 next 36B997B0 cur_rx 123 rxbd sl 80000000 buffer 3B759040 sl 00000000 next 36B997C0 cur_rx 124 rxbd sl 80000000 buffer 3B758940 sl 00000000 next 36B997D0 cur_rx 125 rxbd sl 80000000 buffer 3B758240 sl 00000000 next 36B997E0 cur_rx 126 rxbd sl 80000000 buffer 3B687940 sl 00000000 next 36B997F0 cur_rx 127 rxbd sl 80000000 buffer 3B687240 sl 00000000 next 36B99000 cur_rx 0 rxbd sl 80000000 buffer 3B6A7940 sl 00000000 next 36B99010 cur_rx 1 rxbd sl 80000000 buffer 3B6A7240 sl 00000000 next 36B99020 rxd_of 127 rxbd sl 80000000 buffer 3B687240 sl 00000000 next 36B99000 rxd_of 0 rxbd sl 80000000 buffer 3B6A7940 sl 00000000 next 36B99010 rxd_of 1 rxbd sl 80000000 buffer 3B6A7240 sl 00000000 next 36B99020 ***@***.***:~# Still working on verifying NC-SI with the EMAC driver on our board, but what I found is that using seq_read will crash the kernel. So this is a patch just to get unblocked. Thanks, Kun On Mon, Jun 18, 2018 at 4:10 AM Avi Fishman ***@***.***> wrote: > Hi Kun, > > Did you try to do "cat /proc/driver/npcm7xx_emc.0" after th echange and is > it working well? > > Avi > > On Mon, Jun 18, 2018 at 8:32 AM Kun Yi ***@***.***> wrote: > > > Procfs read should be npcm7xx_proc_read function so that the read > > operation correctly allocates dump memory. > > > > Change-Id: I2bd72fbc5c1668c062c6eb5b95057c7f050b6009 > > Signed-off-by: Kun Yi ***@***.*** > > ------------------------------ > > You can view, comment on, or merge this pull request online at: > > > > #8 > > Commit Summary > > > > - net: npcm7xx: EMAC driver should not directly use seq_read. > > > > File Changes > > > > - *M* drivers/net/ethernet/nuvoton/npcm7xx_emc.c > > <https://github.com/Nuvoton-Israel/linux/pull/8/files#diff-0> (4) > > > > Patch Links: > > > > - https://github.com/Nuvoton-Israel/linux/pull/8.patch > > - https://github.com/Nuvoton-Israel/linux/pull/8.diff > > > > — > > You are receiving this because you are subscribed to this thread. > > Reply to this email directly, view it on GitHub > > <#8>, or mute the thread > > < > https://github.com/notifications/unsubscribe-auth/AbbZSra6QF3eaQoQq5UUF_YC10d8DTu7ks5t9ztQgaJpZM4UrLMn > > > > . > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#8 (comment)>, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AB9Sx6dIJPSubZuHBusLnXy7fZrPlZc5ks5t94qKgaJpZM4UrLMn > > . > -- Regards, Kun — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AbbZSk1M1kpYJgO5pqmaad-_kAsfnXV_ks5t97nlgaJpZM4UrLMn> .