Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme changes are not picked if the custom folder is symlinked #177

Closed
dgmora opened this issue Mar 31, 2023 · 5 comments
Closed

Theme changes are not picked if the custom folder is symlinked #177

dgmora opened this issue Mar 31, 2023 · 5 comments

Comments

@dgmora
Copy link

dgmora commented Mar 31, 2023

This is related to some issues I was reporting in #173.

I'm not sure if this is a priority, but I just wanted to report that it happens.
If the custom folder is a symlink, changes are not picked.

mkdir test/custom

Add chadrc.lua to that folder:

local M = {}

M.ui =  {
  theme = "solarized_dark",
  hl_override = {
    CursorLine = {
       bg = "blue",
       fg = "green",
    },
  },
}

M.mappings = {}

return M

Using this dockerfile:

FROM alpine:latest
WORKDIR /root
RUN apk  add git nodejs neovim ripgrep build-base bash --update
RUN git clone https://github.com/NvChad/NvChad ~/.config/nvim
CMD bash

Build the image

docker build -t nvchad .

This works (copying config to the right place), theme and highlight change live.

docker run -ti --rm -v $PWD/test/custom:/root/test/custom nvchad
# inside
cp -r /root/test/custom /root/.config/nvim/lua/custom
nvim ~/.config/nvim/lua/custom/chadrc.lua
# edit CursorLine colors change real time
exit docker

This doesn't (symlink), changes in the file don't seem to be picked, even after exiting.

docker run -ti --rm -v $PWD/test/custom:/root/test/custom nvchad
# inside
ln -s /root/test/custom /root/.config/nvim/lua/custom
nvim ~/.config/nvim/lua/custom/chadrc.lua
# edit CursorLine colors doesn't change anything, even after re-entering nvim.
@siduck
Copy link
Member

siduck commented Apr 2, 2023

hmm let me test it here

@siduck
Copy link
Member

siduck commented Apr 2, 2023

I get this error when using the symlinked custom dir

image

do you get it?

@dgmora
Copy link
Author

dgmora commented Apr 2, 2023 via email

@siduck
Copy link
Member

siduck commented Apr 12, 2023

hmmm weird, i'll test it this weekend

siduck added a commit to NvChad/NvChad that referenced this issue Jun 15, 2023
@siduck
Copy link
Member

siduck commented Jun 15, 2023

hi @dgmora its finally fixed now! sorry for taking too long

@siduck siduck closed this as completed Jun 15, 2023
camfrey pushed a commit to camfrey/NvFrey that referenced this issue Jun 23, 2023
lianghx-319 pushed a commit to lianghx-319/NvChad that referenced this issue Jun 24, 2023
lianghx-319 pushed a commit to lianghx-319/NvChad that referenced this issue Jun 28, 2023
treble37 pushed a commit to treble37/NvChad that referenced this issue Jul 20, 2023
xtxe pushed a commit to xtxe/NvChad that referenced this issue Aug 13, 2023
goraxe added a commit to goraxe/configfiles that referenced this issue Sep 12, 2023
215aa2b Revert "rm useless luasnip calls"
617dca4 add fzf telescope extension to improve sorting performance (#2371)
de85977 rm useless luasnip calls
456ae88 include MasonUpdate cmd for mason.nvim lazyloading
a69e8dc feat(lsp): add visual mode code actions (#2353)
a9bc954 refactor: gen chadrc template (#2349)
3f1e6d7 make whichkey lazyloadable by its cmd | fix #2342
9c013a6 updated lazygit keys for which-key plugin (#2331)
d3d9aa2 rm config func from UI plugin spec
46a6107 clean up
8ea74bc update some module paths
487ca44 update icon paths
05f5819 feat: added .ignore file (#2271)
6766ace dont disable editor config with lazy_nvim
0e27cb4 dont reload tabufline if its disabled #2236
682b023 make tabufline reloadable
f18488d feat: ignore after folder (#2228)
720d71b Update README.md (#2194)
08f3deb temporarily revert blankline to stable version #2189
3500e73 Catch errors from shell calls (#2188)
83aac1e fix: wildcard pattern usage in `fs_realpath` (#2152)
10b668d make formatting mapping <leader>fm as general mapping #2167
286c951 fix: make key mapping's description to lazy load Comment.nvim coherent with the defaults (#2148)
4aa2831 Fix too long descriptions for Comment.nvim's key mapping and add g key to trigger which-key (#2145)
212bb9a Improved keys property for Comment.vim (#2144)
11c839f Defaulting to not installing custom config in --headless mode (#2132)
d3433e3 feat: ignore syntax folder (#2124)
8ba64ff custom config reload: support symlinks NvChad/base46#177
e3bb391 Fix default mappings not load if chadrc.lua does not exist (#2037)
a18d92d Update README.md
d73d155 disable semantic tokens only if the LSP supports it
27992ef Merge pull request #2031 from TirtharajPramanik/patch-1
1d26f9d Merge pull request #2097 from azuwis/telescope
c2a0bb1 telescope: Explicitly depend on nvim-treesitter
c3c349c Change cmp to insert completion instead of replacing the current word (#2083)
f8a489e include editor config in lazy disabled_plugins list
d72d935 Fix deprecated highlight config for gitsigns (#2078)
9c10201 Fix Comment.nvim not lazyloading from visual mode (#2067)
582dff9 allow to override default config of comment.nvim (#2045)
262a067 change mapping for telescope marks
f6229b4 add mapping for telescope bookmarks (#2035)
1cb237f rm outdated icons
c8a1aa2 use old dir icon for nvimtree
a54e4e9 chore: consistent border style when navigating diagnostics (#2033)
914f9a4 Update init.lua
699aeaa style(mappings): One style for descriptions (#2018)
e163162 disable LSPs inbuilt formatting by default | FIX (#2016)
3dd0fa6 temporarily change folder icon
03f93e5 update icons to nerdfont icons 3.0x
b51065b fix: readme links (#1974)
907684e include lazyloading of comment.nvim with gcc/gbc keys (#1972)
56e6234 add option for using extended base46 integrations
cff182c remove outdated plugin info in readme
fdb3ddb rm un-needed code
7914da7 include c , v keys in whichkey lazyloading
12f26e9 rm depcreated option from nvimtree config
34bdca1 clean up
af123ee handle semantic_tokens on lsp_attach based on chadrc option (#1907)
f873d3c add an option for lsp_semantic_tokens hl groups | fix (#1907)
b5cf9fd Added current buffer fuzzy find key mapping (#1903)
907b112 make some mapping keybinds lowercased (#1897)
3479853 feat(mappings): add description to movement keys in normal mode
0619ef4 fix(mappings): fix description of j key in x mode
1754a23 add nvimtree option to preserve window proportions (#1597)
4d45597 gitsign: handling file path with spaces
a5906e4 use function in init opts for all plugins
8ec2cb3 feat: Increase visibility of floating diagnostic
800d066 feat(bootstrap): indicate that no is the default answer
ffdb4fc add show_numbers option to tabufline config
c77c086 add nvimtree_side global in nvimtree config func NvChad/ui#68
55de4b9 fix(cmp): lsp suggestions before snippets
d7f9101 bootstrap.lua: rm useless variables
79805b7 bootstrap: clone base46 to lazy path instead of tmpdir
609000d bootstrap base46 before lazy
ed03799 load defaults cache after lazypath check
432b2c1 just load default bas46 cache instead of giving it lazy priority
0678b32 give priority to defaults hl groups cache
59cee93 reduce loc in boostrap.lua
7ec4515 boostrap mason packages properly
84bdc23 save nvchad cache at nvim data dir
effec96 luasnip: add globals for various types of snippets
208c31f rm outdated info in readme
d1d2523 update nvim version in readme badge
edb80f4 fix: text in readme.md
8214d4e fix NVIM_APPNAME
3353abb remove unused var
3563b5a normalize all paths
9dcaefd add variable for path seperators
a583373 fix #1832

git-subtree-dir: nvim
git-subtree-split: 215aa2bb2ff702014132c629d9c995246234fe0e
exellentcoin26 pushed a commit to exellentcoin26/NvChad that referenced this issue Sep 27, 2023
michaelvanstraten added a commit to michaelvanstraten/dotfiles that referenced this issue Oct 1, 2023
47e9ce90 use slim chars for blankline indent
f48ff142 migrate to blankline v3.0 ( breaking change )
4a8fb691 lspconfig file: place default conf in a function
cb18b424 misc
1afbaef5 properly disable lsp signature
d58ec3f5 properly disable lsp signature
17a8959b add option for term auto_insert
1b20da01 update version in core/default_config.lua
d9b3980e update ui plugin branch
92b7f38e rm nvterm & use ui.term related mappings
e868fab1 add options for term module win resize vals
3091ea58 Keep visual selection when indent (#2382)
215aa2bb Revert "rm useless luasnip calls"
617dca4d add fzf telescope extension to improve sorting performance (#2371)
de859773 rm useless luasnip calls
456ae88f include MasonUpdate cmd for mason.nvim lazyloading
a69e8dc5 feat(lsp): add visual mode code actions (#2353)
a9bc954d refactor: gen chadrc template (#2349)
3f1e6d71 make whichkey lazyloadable by its cmd | fix #2342
9c013a6a updated lazygit keys for which-key plugin (#2331)
d3d9aa25 rm config func from UI plugin spec
46a61073 clean up
8ea74bc2 update some module paths
487ca445 update icon paths
05f58191 feat: added .ignore file (#2271)
6766acef dont disable editor config with lazy_nvim
0e27cb4b dont reload tabufline if its disabled #2236
682b023f make tabufline reloadable
f18488d4 feat: ignore after folder (#2228)
720d71b5 Update README.md (#2194)
08f3deb9 temporarily revert blankline to stable version #2189
3500e738 Catch errors from shell calls (#2188)
83aac1ec fix: wildcard pattern usage in `fs_realpath` (#2152)
10b668d9 make formatting mapping <leader>fm as general mapping #2167
286c951d fix: make key mapping's description to lazy load Comment.nvim coherent with the defaults (#2148)
4aa28311 Fix too long descriptions for Comment.nvim's key mapping and add g key to trigger which-key (#2145)
212bb9a6 Improved keys property for Comment.vim (#2144)
11c839f8 Defaulting to not installing custom config in --headless mode (#2132)
d3433e3c feat: ignore syntax folder (#2124)
8ba64ff3 custom config reload: support symlinks NvChad/base46#177
e3bb3910 Fix default mappings not load if chadrc.lua does not exist (#2037)
a18d92df Update README.md
d73d1552 disable semantic tokens only if the LSP supports it
27992efc Merge pull request #2031 from TirtharajPramanik/patch-1
1d26f9dc Merge pull request #2097 from azuwis/telescope
c2a0bb16 telescope: Explicitly depend on nvim-treesitter
c3c349c8 Change cmp to insert completion instead of replacing the current word (#2083)
f8a489ea include editor config in lazy disabled_plugins list
d72d935b Fix deprecated highlight config for gitsigns (#2078)
9c10201e Fix Comment.nvim not lazyloading from visual mode (#2067)
582dff94 allow to override default config of comment.nvim (#2045)
262a0677 change mapping for telescope marks
f6229b4b add mapping for telescope bookmarks (#2035)
1cb237fa rm outdated icons
c8a1aa2e use old dir icon for nvimtree
a54e4e92 chore: consistent border style when navigating diagnostics (#2033)
914f9a40 Update init.lua
699aeaa4 style(mappings): One style for descriptions (#2018)
e1631629 disable LSPs inbuilt formatting by default | FIX (#2016)
3dd0fa6c temporarily change folder icon
03f93e5d update icons to nerdfont icons 3.0x
b51065b1 fix: readme links (#1974)
907684ef include lazyloading of comment.nvim with gcc/gbc keys (#1972)
56e62343 add option for using extended base46 integrations
cff182ce remove outdated plugin info in readme
fdb3ddb8 rm un-needed code
7914da7c include c , v keys in whichkey lazyloading
12f26e91 rm depcreated option from nvimtree config
34bdca17 clean up
af123eee handle semantic_tokens on lsp_attach based on chadrc option (#1907)
f873d3cc add an option for lsp_semantic_tokens hl groups | fix (#1907)
b5cf9fde Added current buffer fuzzy find key mapping (#1903)
907b1125 make some mapping keybinds lowercased (#1897)
3479853e feat(mappings): add description to movement keys in normal mode
0619ef4e fix(mappings): fix description of j key in x mode
1754a23e add nvimtree option to preserve window proportions (#1597)
4d455974 gitsign: handling file path with spaces
a5906e48 use function in init opts for all plugins
8ec2cb3b feat: Increase visibility of floating diagnostic
800d066a feat(bootstrap): indicate that no is the default answer
ffdb4fc5 add show_numbers option to tabufline config
c77c0863 add nvimtree_side global in nvimtree config func NvChad/ui#68
55de4b9c fix(cmp): lsp suggestions before snippets
d7f91016 bootstrap.lua: rm useless variables
79805b7f bootstrap: clone base46 to lazy path instead of tmpdir
609000db bootstrap base46 before lazy
ed037996 load defaults cache after lazypath check
432b2c1c just load default bas46 cache instead of giving it lazy priority
0678b329 give priority to defaults hl groups cache
59cee93f reduce loc in boostrap.lua
7ec45151 boostrap mason packages properly
84bdc233 save nvchad cache at nvim data dir
effec96b luasnip: add globals for various types of snippets
208c31f2 rm outdated info in readme
d1d25231 update nvim version in readme badge
edb80f4e fix: text in readme.md
8214d4e8 fix NVIM_APPNAME
3353abb4 remove unused var
3563b5af normalize all paths
9dcaefd7 add variable for path seperators
a5833730 fix #1832

git-subtree-dir: .config/nvim
git-subtree-split: 47e9ce90ff07db8b20a4c7afae30210c0747525f
adylanrff pushed a commit to adylanrff/.nvim that referenced this issue Oct 6, 2023
xtxe pushed a commit to xtxe/NvChad that referenced this issue Dec 2, 2023
le4ker pushed a commit to le4ker/NvMegaChad that referenced this issue Feb 13, 2024
chkg2a pushed a commit to chkg2a/nvchad-implementation-depri that referenced this issue Feb 14, 2024
PraveenGongada pushed a commit to PraveenGongada/NvChad that referenced this issue Feb 18, 2024
le4ker pushed a commit to le4ker/NvMegaChad that referenced this issue Feb 21, 2024
le4ker pushed a commit to le4ker/NvMegaChad that referenced this issue Feb 27, 2024
le4ker pushed a commit to le4ker/NvMegaChad that referenced this issue Feb 27, 2024
ethanh6 pushed a commit to ethanh6/NvChad that referenced this issue Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants