Added psalm action #155
Merged
Added psalm action #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, but should we also try and fix the BC Check in this PR, if we are looking at the automated checks? Or do you want to address that one seperately? |
|
We are waiting for 4.9.1 on Roave/Better-reflection. My fix just got merged today: Roave/BetterReflection#690 |
|
Dejavu looking at that issue. I think I saw it before but somehow forgot to subscribe to it 🤦♀️ Approving this PR! |
Zegnat
approved these changes
Oct 1, 2020
|
Thank you for the reviews. CI is green now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also locked/fixed the version of other checks.