Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate examples #1610

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Translate examples #1610

merged 1 commit into from
Jul 2, 2018

Conversation

felzan
Copy link
Contributor

@felzan felzan commented Jun 22, 2018

Translated two examples from portuguese to english

@felzan
Translate examples
9cfc32b 
Translated two examples from portuguese to english
@MikeRalphson
Copy link
Member

Thanks for resubmitting. Perhaps mapping canine to Dog would be a clearer example?

@felzan
Copy link
Contributor Author

felzan commented Jun 25, 2018

It could be the family (canine) for the reason of the "pet type", but for a simpler example it's better be just dog.

@webron webron merged commit 9852c04 into OAI:v3.0.2-dev Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrelmiller darrelmiller darrelmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felzan @MikeRalphson @darrelmiller @webron