-
Notifications
You must be signed in to change notification settings - Fork 9.1k
[OpenAPI.next] validate (not lint) versions/3.*.md with mdv #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't know how, but it looks like a bunch of things got messed up when you look at the rendered view. |
Can the check to add ```text be configured and removed? It's not really needed and just adds noise. |
@webron thanks for the heads-up. The raw diff looked ok. Will rework, |
11af30e
to
d099604
Compare
@webron commits reworked but table-formatting issues still remain. My theory is that GitHub have recently changed their markdown renderer and the You can see the same problem in an unrelated PR by @willdady here. The following markdown Column A|Column B|Column C|Overflow
---|---|---|---
Cell A|Cell <span>|</span>B|Cell C renders as:
One option is to use another Unicode bar character:
Or escaping as per the GFM spec:
I suspect the 'published' versions/3.0.md at RC0 is showing cached html from before the change. |
Thanks. I'll look into it. |
d099604
to
363e34d
Compare
@MikeRalphson - I should have merged the PRs in a different order, but alas... I'm trying to manually resolve issues for some PRs but would you mind resolving these yourself? |
@MikeRalphson I see you're pushing changes, lmk when done. |
@webron those four conflicts (between fixed links and fixed table formatting) are resolved. |
Checks for broken links and images with missing alt tags
and fenced code-blocks with no defined language.This change also updates the Node.js version used on Travis from 0.10.36 (which is now unsupported) to a LTS version (6.x)
Issues identified have been fixed.