-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal with raw HTML snippets post pandoc conversion #2
Comments
Does not alter the actual tables in the BOSC schedule pages: $ sed -i 's#<table border="0">#<table style="border: none !important;">#g' BOSC_????.md BOSC_????_Panel.md Codefest_*.md Note this simpler attempt did not work, I presume the theme CSS overrode it: $ sed -i 's#<table>#<table border="0">#g' BOSC_????.md BOSC_????_Panel.md Codefest_*.md Closes #2, I think.
With the progress on #10 the logo tables were looking much better, they just needed their borders turned off. I've not spotted any other raw HTML issues. These attempts failed - note we do not want hide the borders in the actual tables in the BOSC schedule pages, just the layout tables for image placement:
|
Looks like we'd need to override this at the level, or tweak the theme - quoting https://github.com/pages-themes/cayman/blob/master/_sass/jekyll-theme-cayman.scss table {
display: block;
width: 100%;
overflow: auto;
word-break: normal;
word-break: keep-all; // For Firefox to horizontally scroll wider tables.
-webkit-overflow-scrolling: touch;
th {
font-weight: bold;
}
th,
td {
padding: 0.5rem 1rem;
border: 1px solid $table-border-color;
}
} e.g. Set |
I wrongly tried the code background color previously See #2
Transparent worked, although it might now be worth forcing a border on the schedule pages, e.g. https://obf.github.io/wiki/BOSC_2017_Schedule |
Also the at-a-glance tables have lost a column each in https://obf.github.io/wiki/BOSC_2017_Schedule compared to https://obf.github.io/wiki/BOSC_2017_Schedule |
This is to hide the image layout tables used for sponsors logos etc. We may want to override this for the schedule tables. See #2
Missing columns on the BOSC 2017 schedule fixed in 2c7ee04 Another table issue had dropped the Bina logo from some sponsorship listings, fixed in 55c131e and 5dc2644 I can't say for sure that I have checked every page by eye, but I'm not aware of anything further. Which is not to say there are bits where the layout could be improved ;) |
There are some HTML snippets left in the post conversion markdown. These need to be reviewed and addressed individually.
e.g. the main page used HTML for the blue donation box layout, with mediawiki text within it. This resulted in Markdown within an HTML block which does not render as expected. This might be best resolved by turning the contents of the blue box into HTML too?Done in 994f421The text was updated successfully, but these errors were encountered: