Additional license properties to warn on for principle 1

[balhoff]

I added two additional properties that ontologies may be using for license info. This way we can warn about standardizing rather than stating the ontology doesn't have license info (see discussion in OBOFoundry/OBOFoundry.github.io#1019).

[balhoff]

@beckyjackson I didn't actually run this code (not sure how to, sorry!). Would you be able to check it?

[jamesaoverton]

Thanks @balhoff! @beckyjackson I think we should add "bad license predicate" to the list of fixes?

[beckyjackson]

This seems to run fine so far, I just kicked off a few small builds with no issues. @balhoff do you know of any ontologies that use those other "bad license" properties? I want to test it on one of those to make sure it catches.

You can always run the code with:

make all

Or for a specific ontology (replace obi with whatever namespace you want):

make obi

[balhoff]

CDAO is one.

[hlapp]

Any reason that using dcterms:rights is considered bad? (It is a superproperty of dcterms:license.)

[balhoff]

I think we are just trying for consistency.

[wdduncan]

@balhoff Does this need to be merged? It has been open for a while?

[balhoff]

@wdduncan I think it should be merged.

[jamesaoverton]

Yes, it should just be merged. Sorry that I didn't just do that months ago. Go ahead @wdduncan