[FIX] calling name_get can cause tracebacks when printing reports

[hbrunn]

https://code.launchpad.net/~therp-nl/ocb-web/7.0_lp1340813/+merge/226488

[pedrobaeza]

👍 (code review)

[StefanRijnhart]

👍 Can you propose the same improvement into the original fix: https://code.launchpad.net/~therp-nl/openerp-web/7.0_lp1261322_better_report_name/+merge/220777 or better, propose the improved fix on Odoo on GitHub?

[hbrunn]

I just fixed a small annoyance with this patch: When reporting over multiple objects and depending on their names, we might get a very long file name, which causes at least chrome to refuse to save the file, giving the user extra hassle. So truncating to some sane length seems a good idea.

[pedrobaeza]

Yeah, I have experimented this, so this little hack it's welcome.

[pedrobaeza]

Do we proceed with the merge?

[coveralls]

Changes Unknown when pulling 1a4d05f on hbrunn:7.0_lp1340813 into * on OCA:7.0*.

[moylop260]

If you run test purchase_requisition/test/purchase_requisition.yml with this PR
The result is:

I create the procurement order and run that procurement.
Creating !record {model: make.procurement, id: procurement_product_hdd3}
Creating !python {model: make.procurement}: |
I run the scheduler.
I check requisition details which created after run procurement.
I open another requisition.
Supplier send one RFQ so I create requisition request of that supplier.
Creating !record {model: purchase.requisition.partner, id: requisition_partner_0}
Creating !python {model: purchase.requisition.partner}:
I check that the RFQ details which created for supplier.
I confirmed RFQ which has best price.
I check status of requisition after confirmed best RFQ.
I print a Requisition report
I check that I cannot cancel the requisition:

ERROR AssertionError in Python code : tender_cancel should have failed

You can check log here:
runbot ocb
log.txt

[pedrobaeza]

@moylop260, are you sure the error is due to this patch?

Regards.

[moylop260]

@pedrobaeza,
Maybe with a rebase will be fixed.
Last commit date (before of patch) is two month ago.