[FIX] Replace PIL by pillow. #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the binary is gone from upstream: http://effbot.org/downloads#pil (linked from https://pypi.python.org/pypi/PIL), so 👍 Does anybody know what the background here? |
|
I guess https://github.com/therp/odoo/tree/7.0-use_pillow was never proposed? Thanks for this PR. Can you refer to the upstream PR on Odoo? |
|
@StefanRijnhart I doubt wether Odoo SA will do anything with fixes for 7.0, but here is my PR: |
|
👍 |
mistotebe
pushed a commit
to credativUK/OCB
that referenced
this pull request
Jun 2, 2016
[FIX] use pillow instead of PIL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Use of PIL library, instead of pillow, is deprecated and leads to failure when installing odoo through buildout
Current behavior before PR:
Buildout fails with message:
Getting distribution for 'PIL'.
anybox.recipe.odoo.base: Could not find or install 'PIL'. You don't need to require it for Odoo any more, since the recipe automatically adds a dependency to Pillow. If you really need it for other reasons, installing it system-wide is a good option. Original exception zc.buildout.easy_install.MissingDistribution says: Couldn't find a distribution for 'PIL'.
While:
Installing odoo.
Error: Couldn't find a distribution for 'PIL'.
Desired behavior after PR is merged:
Buildout succeeds.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr