-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.0 'mail' (onesteinbv) #116
Conversation
[retracted thumbs up] |
As noted in #64 (comment), we need to migrate the alias parent fields |
I'll provide a general function for this that the other migration scripts can use |
946b82c
to
f163207
Compare
This function already exists, I needed to rebase this on current 8.0 to make use of it |
8.0 'mail' (onesteinbv)
👍 |
], | ||
'mail_mail': [ | ||
('email_from', None), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this empty line?
[FIX] Don't call map_values with the same source and target table [ADD] Load noupdate data
8b1616d
to
47e73dc
Compare
Thanks for the review, guys. I took this up and committed your suggestions. Looks fine by me now. 👍 |
👍 for me too I merge. |
Port 'mail' modification realized by OneStein BV. (branch onesteinbv:8.0-os)