Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0 'mail' (onesteinbv) #116

Merged
merged 4 commits into from
Dec 18, 2014
Merged

Conversation

legalsylvain
Copy link
Contributor

Port 'mail' modification realized by OneStein BV. (branch onesteinbv:8.0-os)

@legalsylvain legalsylvain added this to the 8.0 milestone Oct 28, 2014
@legalsylvain legalsylvain changed the title [ADD] [8.0] 'mail' migration; 8.0 'mail' (onesteinbv) Oct 28, 2014
@hbrunn
Copy link
Member

hbrunn commented Nov 17, 2014

[retracted thumbs up]

@hbrunn
Copy link
Member

hbrunn commented Nov 28, 2014

As noted in #64 (comment), we need to migrate the alias parent fields

@hbrunn
Copy link
Member

hbrunn commented Nov 28, 2014

I'll provide a general function for this that the other migration scripts can use

@hbrunn
Copy link
Member

hbrunn commented Nov 28, 2014

This function already exists, I needed to rebase this on current 8.0 to make use of it

christophlsa pushed a commit to blooparksystems/OpenUpgrade that referenced this pull request Dec 11, 2014
@hbrunn
Copy link
Member

hbrunn commented Dec 15, 2014

👍

],
'mail_mail': [
('email_from', None),

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this empty line?

[FIX] Don't call map_values with the same source and target table
[ADD] Load noupdate data
@StefanRijnhart
Copy link
Member

Thanks for the review, guys. I took this up and committed your suggestions. Looks fine by me now. 👍

@pedrobaeza
Copy link
Member

👍 for me too

I merge.

pedrobaeza added a commit that referenced this pull request Dec 18, 2014
@pedrobaeza pedrobaeza merged commit 8a47775 into OCA:8.0 Dec 18, 2014
@pedrobaeza pedrobaeza deleted the 8.0-mail-onesteinbv branch December 18, 2014 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants