[16.0][OU-IMP] account: Rectifiy use_in_tax_closing in old repartition lines #4425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field was introduced in v14, but it was not impacting in anything noticeable till this version, where not having this marked in the taxes lines makes that the tax lines take the analytic dimensions no matter if the analytic field is marked or not. As a compromise solution, let's assign this as True for those that have no value, which are those coming from old versions.
sergio-teruel
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field was introduced in v14, but it was not impacting in anything noticeable till this version, where not having this marked in the taxes lines makes that the tax lines take the analytic dimensions no matter if the analytic field is marked or not.
As a compromise solution, let's assign this as True for those that have no value, which are those coming from old versions.
@Tecnativa