Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] [MIG] apps_product_creator: Migration to v13.0 #74

Merged
merged 41 commits into from
Jul 21, 2020

Conversation

CarlosRoca13
Copy link

cc @Tecnativa TT23178

tafaRU and others added 30 commits July 7, 2020 12:45
- Renamed attribute names on product.product model;
- Removed some unused attribute definition on product.product model;
- Attribute image_module on product.template is now not stored;
- Views definition made compliant with OCA guidelines;
- Added values 5, 6, 6.1, 7 and 11 to product attribute Odoo Version;
- On odoo.module form views, replaced "Create Products" with Smartbutton for showing related product variants;
 - Products created from modules are now set as not purchasable and with 0 cost and sell price;
 - Rearranged product.product view definition in "Module Informations" tab;
* [IMP] website_apps_store: remove author filter from shop

* [FIX]apps_product_creator: fix the broken image path problem with github direct link

* [FIX]rename method with proper name

* [FIX] solve the problem for renaming function

* [FIX] reoved the author test cases
* [ADD] Add the Module maturity on the created product variant

* [UPD] Update readme to new format, add changelog
* [IMP] apps-store:

- Shop:
  * Removed filter by author.
  * Added a more informative placeholder to the searchbox
  * Added categories of apps to public categories.
  * Added a filter `All` option for categories dropdown.
  * Removed sort by price.

- Changed the way products are created, now products are related
to their correspondant category. (used the ones from Odoo.com/apps)

- On PDP added the version of the app if it has no variants.

* [REF] if no category found will defailt to 'Other' category
@pedrobaeza pedrobaeza requested a review from Tardo July 16, 2020 10:37
@pedrobaeza
Copy link
Member

@CarlosRoca13 I have tricked the config variable and it's working as you can see.

@CarlosRoca13
Copy link
Author

Thank you very much @pedrobaeza. I will keep it in mind for the next

apps_product_creator/models/odoo_module.py Outdated Show resolved Hide resolved
apps_product_creator/models/odoo_module.py Outdated Show resolved Hide resolved
apps_product_creator/models/odoo_module.py Outdated Show resolved Hide resolved
apps_product_creator/models/odoo_module.py Outdated Show resolved Hide resolved
apps_product_creator/models/odoo_module.py Outdated Show resolved Hide resolved
apps_product_creator/models/product_product.py Outdated Show resolved Hide resolved
apps_product_creator/models/product_product.py Outdated Show resolved Hide resolved
apps_product_creator/models/product_product.py Outdated Show resolved Hide resolved
apps_product_creator/models/product_product.py Outdated Show resolved Hide resolved
@CarlosRoca13 CarlosRoca13 force-pushed the 13.0-MIG-apps_product_creator branch from 924a04a to 7b8801c Compare July 17, 2020 07:14
@CarlosRoca13
Copy link
Author

@Tardo Changes done

bizzappdev and others added 7 commits July 17, 2020 09:26
* [IMP] while clean the odoo module version archive the product

* [FIX]Added new line at the end of file

* [FIX] fix some typo

* [IMP]improve logic with less iterations
* [FIX]update the product for the new version

* [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded

* [IMP]added technical name search functionality

* change version number

* [IMP]Merged create and update product cron job

* [FIX]fix variable names
* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view
* Add XML-ID if 12.0 attribute value was manually added in the DB
* Add in advance 13.0 and 14.0 attribute versions for avoiding this problem in future versions
Translated using Weblate (Italian)

Currently translated at 95.7% (45 of 47 strings)

Translation: apps-store-12.0/apps-store-12.0-apps_product_creator
Translate-URL: https://translation.odoo-community.org/projects/apps-store-12-0/apps-store-12-0-apps_product_creator/it/
@pedrobaeza pedrobaeza force-pushed the 13.0-MIG-apps_product_creator branch from 7b8801c to 940ab94 Compare July 17, 2020 07:26
@CarlosRoca13 CarlosRoca13 force-pushed the 13.0-MIG-apps_product_creator branch from 940ab94 to 8493022 Compare July 17, 2020 07:47
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, thanks! please, check out the new comments...

apps_product_creator/models/odoo_module.py Outdated Show resolved Hide resolved
apps_product_creator/models/odoo_module.py Outdated Show resolved Hide resolved
apps_product_creator/models/product_product.py Outdated Show resolved Hide resolved
apps_product_creator/models/product_product.py Outdated Show resolved Hide resolved
@CarlosRoca13 CarlosRoca13 force-pushed the 13.0-MIG-apps_product_creator branch from 8493022 to 3ec5654 Compare July 21, 2020 08:00
@CarlosRoca13
Copy link
Author

@Tardo Changes done!

Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM Code review

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-74-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fe072b5 into OCA:13.0 Jul 21, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e29c8b3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet