Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[revolution] Port from 8 to 9 + new fields.Phone archi #88

Merged
merged 29 commits into from
Jul 29, 2016

Conversation

alexis-via
Copy link
Contributor

I re-used some of the work of @jmalinens in his PR #75 (I set his name in one of the commits)

Click2dial and one-click access on calling party form is already working fine (updated to work with Asterisk 13).

This is still a work in progress, but it should be finished on Monday evening.

@alexis-via
Copy link
Contributor Author

OK, the port to v9 is ready and fully tested.

@coveralls
Copy link

coveralls commented May 23, 2016

Coverage Status

Coverage decreased (-4.0%) to 54.186% when pulling 81f01f5 on akretion:9-full-port into 1064839 on OCA:9.0.

@alexis-via
Copy link
Contributor Author

FYI, I'm currently evaluating the feasability to make the base_phone and asterisk_click2dial module compatible with the web/enterprise module. It would require a re-organisation of the JS code of base_phone and asterisk_click2dial. I started working on it: if that moves the JS code of base_phone/asterisk_click2dial in the right direction (re-organise JS code between the 2 modules, cleanup our JS code), that I'll commit my work in this branch ; otherwise, it will be just a "try" and I'll drop the idea and the code I'm currently writting.

The revolution in the connector-telephony project has started !
@alexis-via alexis-via changed the title 9.0 Full port from 8 to 9 [revolution] Port from 8 to 9 + new fields.Phone archi Jun 24, 2016
@alexis-via
Copy link
Contributor Author

All the original features should have been restored now... no it should be ready for review/merge.

@alexis-via
Copy link
Contributor Author

This PR is ready to merge.

@alexis-via
Copy link
Contributor Author

Travis is green, so it's really ready to merge now !

@sla-subteno-it
Copy link

👍

@alexis-via
Copy link
Contributor Author

alexis-via commented Jul 20, 2016

EDIT: I was writing a wrong statement. The bug #93 is fixed in my next commit... but we will need to understand why do_notify doesn't work here.

@alexis-via
Copy link
Contributor Author

@christophdb As you are using the branch of this PR, could you approve it ? (As you may know, to merge an OCA PR, we are supposed to have 2 👍).

@alexis-via alexis-via merged commit be71a0b into OCA:9.0 Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants