-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][9.0] contract_payment_mode module #56
Conversation
827acf9
to
f54bcbe
Compare
@cubells, 2 things to do always:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have mixed an outdated branch for sure. Please fix this before continuing the review.
README.md
Outdated
@@ -16,6 +16,7 @@ For Project related extensions please see the | |||
[![Transifex Status](https://www.transifex.com/projects/p/OCA-contract-9-0/chart/image_png)](https://www.transifex.com/projects/p/OCA-contract-9-0) | |||
|
|||
[//]: # (addons) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
contract/README.rst
Outdated
@@ -22,6 +22,7 @@ To use this module, you need to: | |||
#. Go to Sales -> Contracts and select or create a new contract. | |||
#. Check *Generate recurring invoices automatically*. | |||
#. Fill fields for selecting the recurrency and invoice parameters: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one?
@@ -0,0 +1,26 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also this one
01c293a
to
c299945
Compare
bb9ce98
to
71bc6fc
Compare
Please @cubells This branch has conflicts that must be resolved, thanks! |
@rafaelbn done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix
contract_payment_mode/README.rst
Outdated
Click on **Generate recurring invoices automatically** checkbox and add a | ||
product to invoice. | ||
|
||
If you create an invoice, new invoice will have tehe same payment mode of its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you create an invoice, new invoice will have the same payment mode of its
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality tested on runbot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on runbot 👍
* Copy partner payment mode to contracts when installing * Filter payment modes for sales * Adding tests
in recurring invoice
3f6d69b
to
a0efa90
Compare
cc @Tecnativa