Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][9.0] contract_payment_mode module #56

Merged
merged 5 commits into from
Mar 31, 2017

Conversation

cubells
Copy link
Member

@cubells cubells commented Mar 28, 2017

  • Updated views
  • Updated README
  • Updated tests

cc @Tecnativa

@cubells cubells force-pushed the 9.0-mig-contract_payment_mode branch 3 times, most recently from 827acf9 to f54bcbe Compare March 28, 2017 12:11
@pedrobaeza
Copy link
Member

@cubells, 2 things to do always:

  • You have to squash together all "OCA Transbot" commits.
  • Rebase on current branch, to solve conflicts.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have mixed an outdated branch for sure. Please fix this before continuing the review.

README.md Outdated
@@ -16,6 +16,7 @@ For Project related extensions please see the
[![Transifex Status](https://www.transifex.com/projects/p/OCA-contract-9-0/chart/image_png)](https://www.transifex.com/projects/p/OCA-contract-9-0)

[//]: # (addons)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

@@ -22,6 +22,7 @@ To use this module, you need to:
#. Go to Sales -> Contracts and select or create a new contract.
#. Check *Generate recurring invoices automatically*.
#. Fill fields for selecting the recurrency and invoice parameters:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one?

@@ -0,0 +1,26 @@
# -*- coding: utf-8 -*-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also this one

@cubells cubells force-pushed the 9.0-mig-contract_payment_mode branch 4 times, most recently from 01c293a to c299945 Compare March 28, 2017 13:03
@cubells cubells changed the base branch from 10.0 to 9.0 March 28, 2017 13:10
@cubells cubells force-pushed the 9.0-mig-contract_payment_mode branch 3 times, most recently from bb9ce98 to 71bc6fc Compare March 28, 2017 14:51
@rafaelbn rafaelbn added this to the 9.0 milestone Mar 28, 2017
@rafaelbn
Copy link
Member

Please @cubells This branch has conflicts that must be resolved, thanks!

@cubells
Copy link
Member Author

cubells commented Mar 31, 2017

@rafaelbn done

Copy link
Member

@luismontalba luismontalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix

Click on **Generate recurring invoices automatically** checkbox and add a
product to invoice.

If you create an invoice, new invoice will have tehe same payment mode of its
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you create an invoice, new invoice will have the same payment mode of its

Copy link
Member

@luismontalba luismontalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality tested on runbot

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on runbot 👍

@pedrobaeza pedrobaeza force-pushed the 9.0-mig-contract_payment_mode branch from 3f6d69b to a0efa90 Compare March 31, 2017 12:20
@pedrobaeza pedrobaeza merged commit 73cf7a9 into OCA:9.0 Mar 31, 2017
@pedrobaeza pedrobaeza deleted the 9.0-mig-contract_payment_mode branch March 31, 2017 12:57
@pedrobaeza pedrobaeza mentioned this pull request Jun 8, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants