[13.0][MIG] account_credit_control: Migration to 13.0 #54

manuelcalerosolis · 2020-02-18T11:26:03Z

This is the migration to v 13.0 module account_credit_control

@Tecnativa TT21599

ernestotejeda

Thanks @manuelcalerosolis , Good job !!!!

account_credit_control/models/credit_control_line.py

account_credit_control/views/credit_control_line.xml

account_credit_control/views/credit_control_policy.xml

account_credit_control/data/data.xml

account_credit_control/models/credit_control_policy.py

account_credit_control/models/credit_control_line.py

account_credit_control/models/account_move.py

account_credit_control/views/account_move.xml

account_credit_control/views/credit_control_line.xml

account_credit_control/views/credit_control_policy.xml

account_credit_control/views/credit_control_run.xml

account_credit_control/views/res_partner.xml

account_credit_control/wizard/credit_control_policy_changer.py

account_credit_control/models/credit_control_policy.py

account_credit_control/views/credit_control_line.xml

CasVissers-360ERP · 2020-03-23T13:17:51Z

account_credit_control/report/report_credit_control_summary.xml

+                        <tr t-foreach="doc.credit_control_line_ids" t-as="l">
+                            <t t-if="l.invoice_id">
+                                <td>
+                                    <span t-field="l.invoice_id.number"/>


Number is not a field of account.move, name should be sufficient?

@pedrobaeza
I still get:

File "/Users/brahoo/PycharmProjects/cust/odoo-13.0/odoo/addons/base/models/ir_qweb.py", line 363, in _get_field field = record._fields[field_name] KeyError: 'number' Error to render compiling AST KeyError: 'number' Template: account_credit_control.report_credit_control_summary_document Path: /t/t/div/table/tbody/tr/t[1]/td/span Node: <span t-field="l.invoice_id.number"/>

I think the line should be removed. Only name is sufficient.

CasVissers-360ERP

Initial feedback

CasVissers-360ERP · 2020-03-27T06:31:33Z

account_credit_control/wizard/credit_control_communication.py

+                    {
+                        "name": att[0],
+                        "datas": att[1],
+                        "datas_fname": att[0],


Field name is changed to store_fname in v13?

Changed, thanks

CasVissers-360ERP

Incorrect field on ir.attachment found

account_credit_control/models/credit_control_run.py

rafaelbn · 2020-03-31T14:46:58Z

Please don't merge until my review. Thanks

account_credit_control/security/account_security.xml

CasVissers-360ERP

Record rules are incorrect.

* Modify scenarios to be compatible with python scenarios * Voucher/statement related steps * Deprecated step implementation * Print report generation * All tests green * Mail + print of reminder * Broken translations

* Fix failure to confirm invoice when both account_credit_control and account_constraints are installed * use except_orm instead of except_osv * reindent code * Cleanup * use of deprecated field user_email causes permission error in multicompany setting fixed by using the correct 'email' field in the template

* Address in mako template to make sure address is displayed * Remove 'more info here' from report * Add some css to reminder report and set texts taking the whole width of the document * Add a subject in reminder report

* Report use precise mode by default * date_entry fields on line model to be used by report or in next MP on filter group by * reporting layer, + add hook function to get contact address * credit control mail are not in plain text but send as attachement * policy level name is now translatable as it is use in report and mail * permission on invoices because onetomany widget load data even if hidden ... * translation files + lang source * french translation

…ipts

pedrobaeza · 2020-04-02T12:49:51Z

@CasVissers @rafaelbn can you please re-review?

CasVissers-360ERP · 2020-04-29T09:11:59Z

https://drive.google.com/file/d/1piDHuSzMDWha06kQoXrDMh89bijioySg/view

Even though a credit control line has been processed it seems that it is created a 2nd time? Or am I doing something wrong?

pedrobaeza · 2020-04-29T09:38:13Z

Is that happening the same on v12?

CasVissers-360ERP · 2020-04-29T09:42:10Z

No I can't reproduce the same behavior in v12. I think it's wrong any way we look at it?

pedrobaeza · 2020-04-29T09:55:23Z

If this doesn't happen in v12, then indeed it's a problem of the migration. I will take over this PR and check that. Thanks for reviewing.

CasVissers-360ERP · 2020-05-13T07:02:41Z

@pedrobaeza
any progress?

pedrobaeza · 2020-05-13T07:03:42Z

Sorry, not yet. I will try ASAP.

account_credit_control/models/credit_control_policy.py

CasVissers-360ERP

Fix found for level not increasing

CasVissers-360ERP · 2020-06-10T12:28:49Z

@bhaveshselarka
Maybe if you stop spamming it will go a bit faster.

Done in an extra commit for not changing the SHA of the record rules addition, as it's referenced on the migration guide. This can be squashed when migrating the module to upper versions.

pedrobaeza · 2020-06-11T07:39:23Z

Let's finally merge it:

/ocabot merge nobump

OCA-git-bot · 2020-06-11T07:53:11Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-54-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2020-06-11T08:07:12Z

Congratulations, your PR was merged at 5643895. Thanks a lot for contributing to OCA. ❤️

CasVissers-360ERP · 2020-08-19T08:47:28Z

@pedrobaeza
Maybe I missed something here..

Is and not demo data? They are now created when installing/updating the module.

pedrobaeza · 2020-08-19T08:49:42Z

I don't get you.

CasVissers-360ERP · 2020-08-19T08:53:30Z

<record id="a_sale" model="account.account">
        <field name="code">X2020</field>
        <field name="name">Product Sales - (test)</field>
        <field name="user_type_id" ref="account.data_account_type_revenue" />
        <field name="tag_ids" eval="[(6,0,[ref('account.account_tag_operating')])]" />
    </record>
    <!-- sales journal -->
    <record id="sales_journal" model="account.journal">
        <field name="name">Customer Invoices - Test</field>
        <field name="code">TINV</field>
        <field name="type">sale</field>
        <field name="default_credit_account_id" ref="a_sale" />
        <field name="default_debit_account_id" ref="a_sale" />
        <field name="refund_sequence" eval="True" />
    </record>

Is in data.xml, "data/data.xml", is in manifest? I think this is demo data?

pedrobaeza · 2020-08-19T08:57:39Z

Yes, I don't know why they are there. Can you please do a PR amending it?

manuelcalerosolis requested review from OCA-git-bot, pedrobaeza, ernestotejeda and chienandalu February 18, 2020 12:09

ernestotejeda reviewed Feb 18, 2020

View reviewed changes

ernestotejeda suggested changes Feb 19, 2020

View reviewed changes

sergio-teruel force-pushed the 13.0-mig-account_credit_control branch 3 times, most recently from 2b56336 to 97bc743 Compare February 27, 2020 16:43

manuelcalerosolis force-pushed the 13.0-mig-account_credit_control branch 2 times, most recently from 86778c9 to 1879a7f Compare March 4, 2020 10:10

sergio-teruel force-pushed the 13.0-mig-account_credit_control branch from 1879a7f to 8c006cf Compare March 5, 2020 09:09

manuelcalerosolis force-pushed the 13.0-mig-account_credit_control branch from 8c006cf to 3c926ae Compare March 11, 2020 11:49

CasVissers-360ERP reviewed Mar 23, 2020

View reviewed changes

account_credit_control/views/credit_control_line.xml Outdated Show resolved Hide resolved

CasVissers-360ERP reviewed Mar 23, 2020

View reviewed changes

CasVissers-360ERP suggested changes Mar 23, 2020

View reviewed changes

CasVissers-360ERP reviewed Mar 27, 2020

View reviewed changes

CasVissers-360ERP suggested changes Mar 27, 2020

View reviewed changes

carlosdauden reviewed Mar 31, 2020

View reviewed changes

account_credit_control/models/credit_control_run.py Show resolved Hide resolved

sergio-teruel force-pushed the 13.0-mig-account_credit_control branch from 3c926ae to 3505f06 Compare March 31, 2020 14:42

CasVissers-360ERP reviewed Apr 1, 2020

View reviewed changes

account_credit_control/security/account_security.xml Outdated Show resolved Hide resolved

CasVissers-360ERP suggested changes Apr 1, 2020

View reviewed changes

@ and others added 7 commits April 2, 2020 10:22

[MIG] account_credit_control: Renamed and migrated to 6.1

5e45d08

[MIG] account_credit_control: Migration to 7.0

0ccda01

[IMP] account_credit_control: Add scenarios

a0962c0

[IMP+FIX] account_credit_control: Several improvements & fixes

7f02822

* Modify scenarios to be compatible with python scenarios * Voucher/statement related steps * Deprecated step implementation * Print report generation * All tests green * Mail + print of reminder * Broken translations

[FIX+IMP] account_credit_control

2d604cb

* Address in mako template to make sure address is displayed * Remove 'more info here' from report * Add some css to reminder report and set texts taking the whole width of the document * Add a subject in reminder report

[MIG] account_credit_control: Migration to 13.0

eb8873d

pedrobaeza force-pushed the 13.0-mig-account_credit_control branch 2 times, most recently from 4b11e3c to 0960e87 Compare April 2, 2020 12:00

[FIX] account_credit_control: Fix multi-company rules + migration scr…

162cde2

…ipts

pedrobaeza force-pushed the 13.0-mig-account_credit_control branch from 0960e87 to 162cde2 Compare April 2, 2020 12:07

CasVissers-360ERP reviewed Jun 10, 2020

View reviewed changes

account_credit_control/models/credit_control_policy.py Outdated Show resolved Hide resolved

CasVissers-360ERP suggested changes Jun 10, 2020

View reviewed changes

[FIX] account_credit_control: PR reviews

998bbd9

Done in an extra commit for not changing the SHA of the record rules addition, as it's referenced on the migration guide. This can be squashed when migrating the module to upper versions.

pedrobaeza force-pushed the 13.0-mig-account_credit_control branch from 64aa139 to 998bbd9 Compare June 11, 2020 07:38

OCA-git-bot mentioned this pull request Jun 11, 2020

Migration to version 13.0 #29

Closed

6 tasks

OCA-git-bot added the bot is merging ⏳ label Jun 11, 2020

OCA-git-bot merged commit 2615473 into OCA:13.0 Jun 11, 2020

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 11, 2020

pedrobaeza deleted the 13.0-mig-account_credit_control branch August 19, 2020 08:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0][MIG] account_credit_control: Migration to 13.0 #54

[13.0][MIG] account_credit_control: Migration to 13.0 #54

manuelcalerosolis commented Feb 18, 2020

ernestotejeda left a comment

CasVissers-360ERP Mar 23, 2020 •

edited

Loading

CasVissers-360ERP Apr 6, 2020

CasVissers-360ERP left a comment

CasVissers-360ERP Mar 27, 2020

pedrobaeza Apr 2, 2020

CasVissers-360ERP left a comment

rafaelbn commented Mar 31, 2020

CasVissers-360ERP left a comment

pedrobaeza commented Apr 2, 2020

CasVissers-360ERP commented Apr 29, 2020

pedrobaeza commented Apr 29, 2020

CasVissers-360ERP commented Apr 29, 2020

pedrobaeza commented Apr 29, 2020

CasVissers-360ERP commented May 13, 2020

pedrobaeza commented May 13, 2020

CasVissers-360ERP left a comment

CasVissers-360ERP commented Jun 10, 2020

pedrobaeza commented Jun 11, 2020

OCA-git-bot commented Jun 11, 2020

OCA-git-bot commented Jun 11, 2020

CasVissers-360ERP commented Aug 19, 2020

pedrobaeza commented Aug 19, 2020

CasVissers-360ERP commented Aug 19, 2020 •

edited

Loading

pedrobaeza commented Aug 19, 2020

[13.0][MIG] account_credit_control: Migration to 13.0 #54

[13.0][MIG] account_credit_control: Migration to 13.0 #54

Conversation

manuelcalerosolis commented Feb 18, 2020

ernestotejeda left a comment

Choose a reason for hiding this comment

CasVissers-360ERP Mar 23, 2020 • edited Loading

Choose a reason for hiding this comment

CasVissers-360ERP Apr 6, 2020

Choose a reason for hiding this comment

CasVissers-360ERP left a comment

Choose a reason for hiding this comment

CasVissers-360ERP Mar 27, 2020

Choose a reason for hiding this comment

pedrobaeza Apr 2, 2020

Choose a reason for hiding this comment

CasVissers-360ERP left a comment

Choose a reason for hiding this comment

rafaelbn commented Mar 31, 2020

CasVissers-360ERP left a comment

Choose a reason for hiding this comment

pedrobaeza commented Apr 2, 2020

CasVissers-360ERP commented Apr 29, 2020

pedrobaeza commented Apr 29, 2020

CasVissers-360ERP commented Apr 29, 2020

pedrobaeza commented Apr 29, 2020

CasVissers-360ERP commented May 13, 2020

pedrobaeza commented May 13, 2020

CasVissers-360ERP left a comment

Choose a reason for hiding this comment

CasVissers-360ERP commented Jun 10, 2020

pedrobaeza commented Jun 11, 2020

OCA-git-bot commented Jun 11, 2020

OCA-git-bot commented Jun 11, 2020

CasVissers-360ERP commented Aug 19, 2020

pedrobaeza commented Aug 19, 2020

CasVissers-360ERP commented Aug 19, 2020 • edited Loading

pedrobaeza commented Aug 19, 2020

CasVissers-360ERP Mar 23, 2020 •

edited

Loading

CasVissers-360ERP commented Aug 19, 2020 •

edited

Loading