-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0] [IMP] dms: Attachment Integration #24
[12.0] [IMP] dms: Attachment Integration #24
Conversation
dcaa51f
to
eba83ce
Compare
Aren't you able to cherry-pick v13 commit and then put changes for v12 on top of? This way, you preserve the attribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review 👍 . Looks good.
But, I think you should include unit tests for the new functionality
@victoralmau I got an error creating a file in an type-attachment storage: |
ef18795
to
b02fb0c
Compare
Thanks for report this error, solved now. |
Thanks, althought in original PR not exist tests, added now. |
e292d64
to
024c1cd
Compare
024c1cd
to
1b69efc
Compare
1b69efc
to
fad936e
Compare
5517baf
to
b1c650a
Compare
Please don't solve conflicts through merge commits as stated other times. |
1ebd5f3
to
98a4d68
Compare
Sorry, solved it (rebase) |
98a4d68
to
17e4e52
Compare
17e4e52
to
6bc1fbe
Compare
Put in the roadmap to add a migration procedure for converting an storage to attachment one for populating existing records with attachments as folders. Another roadmap point is to add a link from attachment view in chatter to linked documents. |
861895d
to
2c02657
Compare
d52901b
to
78b8d99
Compare
78b8d99
to
6fd248c
Compare
OK, now it's good to continue. I merge as talked with @etobella by chat: /ocabot merge major |
This PR looks fantastic, let's merge it! |
Now I think it's better to cherry-pick this into v13 than continue on the other PR. Please tell in the PR to see what the other contributors think. |
Congratulations, your PR was merged at bd27a0f. Thanks a lot for contributing to OCA. ❤️ |
This feature aims to integrate dms with ir.attachment. That way, every time a new attachment is created, a dms.file is also created with a category according to the model the attachment is in.
Related to (V13): #9
Please @pedrobaeza review it
@Tecnativa TT25646